Updated validate directive to compile the error and success html strings (useful for translation keys)#97
Closed
jamhall wants to merge 2 commits intohueitan:masterfrom
Closed
Updated validate directive to compile the error and success html strings (useful for translation keys)#97jamhall wants to merge 2 commits intohueitan:masterfrom
jamhall wants to merge 2 commits intohueitan:masterfrom
Conversation
Added compile service to compile the error and success strings
Author
|
Reference: #96 |
Owner
|
Hi @jamhall Thanks for this. Would you mind do grunt build on this? |
Author
|
Added :-) |
Owner
|
Close it. Open if needed. |
Owner
|
You are right. I'm thinking about this fix now, it make more sense to us using angular compile. Thanks @jamhall I would like to accept the PR now. Sorry for the delay. |
Owner
|
New PR here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added compile service to compile the error and success strings.
For example, you may wish to use translation keys for the error and success messages:
Please note, I have built it using the
grunt buildtask but I have not commited the build files.Cheers,
Jamie