Cleanup

GeorgeSapkin · GeorgeSapkin · commit 7eb5d1b83714 · 2018-02-24T17:38:15.000+01:00
diff --git a/week3/src/actions/deserializeTodo.js b/week3/src/actions/deserializeTodo.js
@@ -13,9 +13,8 @@ function deserializeTodo(request, response) {
     return null;
   }
 
-  if (todo.description != null) {
+  if (todo.description != null)
     todo.description = todo.description.trim();
-  }
 
   if (todo.description == null || todo.description.length === 0) {
     setError(response, 'Specify a description');
diff --git a/week3/src/actions/read.js b/week3/src/actions/read.js
@@ -8,8 +8,10 @@ function read(todo, request, response) {
     })
     // We are ignoring the actual error
     .catch(error => {
+      console.error(error);
+
       response.status(500);
-      response.json({ error });
+      response.json({ error: 'Internal Server Error' });
     });
 };
 
diff --git a/week3/src/actions/update.js b/week3/src/actions/update.js
@@ -7,8 +7,6 @@ function update(todo, request, response) {
   const _todo = deserializeTodo(request, response);
 
   if (_todo == null) {
-    response.status(400);
-    response.json({ error: 'Bad Request' });
     return;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -13,9 +13,8 @@ function deserializeTodo(request, response) {`
`13`	`13`	`return null;`
`14`	`14`	`}`
`15`	`15`
`16`		`- if (todo.description != null) {`
	`16`	`+ if (todo.description != null)`
`17`	`17`	`todo.description = todo.description.trim();`
`18`		`- }`
`19`	`18`
`20`	`19`	`if (todo.description == null \|\| todo.description.length === 0) {`
`21`	`20`	`setError(response, 'Specify a description');`
Original file line number	Diff line number	Diff line change
`@@ -7,8 +7,6 @@ function update(todo, request, response) {`
`7`	`7`	`const _todo = deserializeTodo(request, response);`
`8`	`8`
`9`	`9`	`if (_todo == null) {`
`10`		`- response.status(400);`
`11`		`- response.json({ error: 'Bad Request' });`
`12`	`10`	`return;`
`13`	`11`	`}`
`14`	`12`