Cleanup and refactoring

GeorgeSapkin · GeorgeSapkin · commit f01544597f6d · 2018-03-10T20:29:06.000+01:00
diff --git a/week3/lecture/package.json b/week3/lecture/package.json
@@ -1,7 +1,7 @@
 {
   "name": "hyf-node-week-3-todo",
   "version": "1.0.0",
-  "description": "HackYourFuture Node.js Week 3 - Todo App",
+  "description": "HackYourFuture Node.js Week 3 - To-Do App",
   "repository": "https://github.com/HackYourFuture/nodejs.git",
   "main": "src/index.js",
   "author": "George Sapkin",
diff --git a/week3/lecture/src/actions/deserializeTodo.js b/week3/lecture/src/actions/deserializeTodo.js
@@ -7,9 +7,9 @@ function setError(response, error) {
 }
 
 function deserializeTodo(request, response) {
-  const todo = request.body.todo;
+  const { todo } = request.body;
   if (todo == null) {
-    setError(response, 'Specify a todo');
+    setError(response, 'Specify a to-do');
     return null;
   }
 
diff --git a/week3/lecture/src/todo.js b/week3/lecture/src/todo.js
@@ -1,8 +1,11 @@
+
 'use strict';
 
 const fs   = require('fs');
 const uuid = require('uuid/v4');
 
+const DEFAULT_ENCODING = 'utf8';
+
 class Todo {
   constructor(filename) {
     this._filename = filename;
@@ -27,7 +30,7 @@ class Todo {
 
   read() {
     return new Promise(resolve => {
-      fs.readFile(this._filename, 'utf-8', (error, data) => {
+      fs.readFile(this._filename, DEFAULT_ENCODING, (error, data) => {
         if (error)
           return resolve([]);
 
@@ -41,7 +44,7 @@ class Todo {
 
     const todo = todos.find(t => t.id === id);
     if (todo == null) {
-      const error = new Error(`Todo with ID ${id} does not exist`);
+      const error = new Error(`To-do with ID ${id} does not exist`);
       error.code = 'not-found';
       throw error;
     }

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "hyf-node-week-3-todo",`
`3`	`3`	`"version": "1.0.0",`
`4`		`- "description": "HackYourFuture Node.js Week 3 - Todo App",`
	`4`	`+ "description": "HackYourFuture Node.js Week 3 - To-Do App",`
`5`	`5`	`"repository": "https://github.com/HackYourFuture/nodejs.git",`
`6`	`6`	`"main": "src/index.js",`
`7`	`7`	`"author": "George Sapkin",`
Original file line number	Diff line number	Diff line change
`@@ -7,9 +7,9 @@ function setError(response, error) {`
`7`	`7`	`}`
`8`	`8`
`9`	`9`	`function deserializeTodo(request, response) {`
`10`		`- const todo = request.body.todo;`
	`10`	`+ const { todo } = request.body;`
`11`	`11`	`if (todo == null) {`
`12`		`- setError(response, 'Specify a todo');`
	`12`	`+ setError(response, 'Specify a to-do');`
`13`	`13`	`return null;`
`14`	`14`	`}`
`15`	`15`