Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 8f25ea2

Browse files
authored
[NFC] Leave a comment in Local.cpp about debug info & sample profiling (llvm#155296)
Issue llvm#152767
1 parent 9e33997 commit 8f25ea2

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

llvm/lib/Transforms/Utils/Local.cpp

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3342,8 +3342,11 @@ void llvm::hoistAllInstructionsInto(BasicBlock *DomBlock, Instruction *InsertPt,
33423342
// retain their original debug locations (DILocations) and debug intrinsic
33433343
// instructions.
33443344
//
3345-
// Doing so would degrade the debugging experience and adversely affect the
3346-
// accuracy of profiling information.
3345+
// Doing so would degrade the debugging experience.
3346+
//
3347+
// FIXME: Issue #152767: debug info should also be the same as the
3348+
// original branch, **if** the user explicitly indicated that (for sampling
3349+
// PGO)
33473350
//
33483351
// Currently, when hoisting the instructions, we take the following actions:
33493352
// - Remove their debug intrinsic instructions.

0 commit comments

Comments
 (0)