[AST] Require a SourceRange for ErrorTypeRepr

hamishknight · hamishknight · commit d2deaa912964 · 2025-09-11T13:21:03.000+01:00
diff --git a/include/swift/AST/TypeRepr.h b/include/swift/AST/TypeRepr.h
@@ -229,11 +229,6 @@ class ErrorTypeRepr : public TypeRepr {
     return new (Context) ErrorTypeRepr(Range);
   }
 
-  static ErrorTypeRepr *
-  create(ASTContext &Context, SourceLoc Loc = SourceLoc()) {
-    return create(Context, SourceRange(Loc));
-  }
-
   static bool classof(const TypeRepr *T) {
     return T->getKind() == TypeReprKind::Error;
   }
diff --git a/lib/Parse/ParseDecl.cpp b/lib/Parse/ParseDecl.cpp
@@ -9935,7 +9935,8 @@ Parser::parseDeclSubscript(SourceLoc StaticLoc,
 
     if (ElementTy.isNull()) {
       // Always set an element type.
-      ElementTy = makeParserResult(ElementTy, ErrorTypeRepr::create(Context));
+      ElementTy = makeParserResult(
+          ElementTy, ErrorTypeRepr::create(Context, getTypeErrorLoc()));
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -229,11 +229,6 @@ class ErrorTypeRepr : public TypeRepr {`
`229`	`229`	`return new (Context) ErrorTypeRepr(Range);`
`230`	`230`	`}`
`231`	`231`
`232`		`- static ErrorTypeRepr *`
`233`		`- create(ASTContext &Context, SourceLoc Loc = SourceLoc()) {`
`234`		`- return create(Context, SourceRange(Loc));`
`235`		`- }`
`236`		`-`
`237`	`232`	`static bool classof(const TypeRepr *T) {`
`238`	`233`	`return T->getKind() == TypeReprKind::Error;`
`239`	`234`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9935,7 +9935,8 @@ Parser::parseDeclSubscript(SourceLoc StaticLoc,`
`9935`	`9935`
`9936`	`9936`	`if (ElementTy.isNull()) {`
`9937`	`9937`	`// Always set an element type.`
`9938`		`- ElementTy = makeParserResult(ElementTy, ErrorTypeRepr::create(Context));`
	`9938`	`+ ElementTy = makeParserResult(`
	`9939`	`+ ElementTy, ErrorTypeRepr::create(Context, getTypeErrorLoc()));`
`9939`	`9940`	`}`
`9940`	`9941`	`}`
`9941`	`9942`