This repository was archived by the owner on Aug 12, 2022. It is now read-only.
This repository was archived by the owner on Aug 12, 2022. It is now read-only.
Meeting - 2/20/2019 #3
Closed
Description
Agenda
- News/announcements
- Review previous action items
- Project
- Acquire a top level domain for CRA homepage (@ianschmitz)
- Should we consider a 2018 roadmap - allowing for feedback? (@mrmckeb)
- Technical
- Publish canary builds on master (and PRs? - babel is a good example of this) (@ianschmitz)
- Can we improve the Storybook experience? We see issues around this quite often. (@mrmckeb)
- TypeScript
- Discuss
typescript-eslint
again - is it ready for prime time? (@mrmckeb)
- Discuss
- CI
- What ever happened to AppVeyor?
- It seems to have just stopped working
- What other CI options are out there?
- We need Windows support
- Mac is nice to have too
- Open source plan or convince someone to donate it to us
- Unit test flakiness
- Looks like tests are currently only failing on Node 11
- What ever happened to AppVeyor?
- Node Tooling Working Group
- Templates
- Discussion on POC (will be ready prior to this meeting) (@mrmckeb)
- v3
- Due to Jest security issues we should try and get this out ASAP
- Publish under
next
and try to get a bit of feedback before releasing widely
- Publish under
- Include only Jest 24 upgrade and hooks eslint plugin?
- Also include eslint typescript plugin?
- Due to Jest security issues we should try and get this out ASAP
- v2.1.x
- 2.1.4 release issues
- Is there anything we could have done differently
- 2.1.5 unresolved issues
- FOUC due to CSS sourcemaps
- Anything blocking us from releasing v3?
- 2.1.4 release issues
- Issues and PRs
- Self-assignment, let's try to keep doing this? (@mrmckeb). It helps to quick identify which issues haven't been looked at (as comment counts aren't helpful).
- Don't be afraid to assign someone else
- They were discussing an issue and then someone submitted a PR, etc.
- If someone assigns you to something don't be offended, you can always un-assign yourself
- If you don't want to assign yourself and don't know who to assign then add it to the issue or PR triage project
- Currently only have one issue template but GitHub now supports multiple for bug report, feature request
Attendees
Notes
- Project
- Domain name
- Look into .dev domains
- Available soon for cheap, can preorder for $$$
- Look into .dev domains
- Logo
- Designer available through Facebook
- Moving to own org
- Dan is onboard
- Talk to Eric Nakagawa from Facebook
- Roadmap
- Based on releases rather than year (v3, v4, etc.)
- Domain name
- Technical
- Docs deploy
- Automated on merge to master is good but how do we deal with new, unreleased features?
- Maybe just comment those pieces out
- Tag comment with release version number so they are easy to find and remove after release
- Automated on merge to master is good but how do we deal with new, unreleased features?
- Template prototype close to ready
- Brody will share in a PR soon
- What if user specifies both scripts-version and a template?
- Maybe warn them that they might be incompatible
- Publish canary version on merge to master and PR
- Start with merge to master or daily/nightly
- PR based releases are risky because someone could include bad code that would be published to npm
- Storybook
- Maybe move some of our dependencies to react-dev-utils?
- Make it easier for other projects to import our dependencies
- Maybe help reduce conflicts between dependencies
- Maybe they should make certain packages peer dependencies?
- Maybe move some of our dependencies to react-dev-utils?
- Docs deploy
- v3
- Things we really want:
- Jest 24
- eslint hooks plugin
- eslint typescript plugin
- babel-plugin-optimize-react - is it ready?
- PR: Adds Babel plugin babel-plugin-optimize-react facebook/create-react-app#6219
- Can we get some simplified version of it in?
- Nice to have
- Maybe support aliases for TypeScript
- Things we really want:
- 2.1.4 release - what went wrong?
- Add label on GitHub for any breaking changes
- Always publish a pre-release, even for minor releases
- 2.1.5
- Revert CSS sourcemaps
- Release 2.1.6
- Issues with babel-preset-react-app
- Not a blocker
- Why is this only affecting some people?
- CI
- AppVeyor just stopped working
- Just let it go and find something new
- Remove old config
- Might be able to use Azure DevOps
- Someone from there reached out to Dan/Facebook
- How do we run scripts on Windows
- Maybe convert to ShellJS?
- Look into how this worked on AppVeyor
- Node 11
- Most test failures are on Node 11
- Only run on LTS versions
- Remove Node 11 from Travis config
- It's nice to have the option of testing on new versions but it shouldn't break the build
- AppVeyor just stopped working
- Issues and PRs
- Try new PR process for the next two weeks
- Create a new label for "Install Issues"
- Look into using more GitHub issues templates
- Record some pre-canned responses to common install issues
- Maybe there's a Chrome plugin that can help with this?
Previous Action Items
- Improve labels
- Add a "Troubleshooting" section to the docs for common install issues
- Automate docs deploy (@iansu)
Get Algolia credentials (@iansu)Create a shared folder in Google Docs for maintainers (@iansu)- Document triaging process (@iansu)
- Document PR process (@iansu)
- Create maintainer onboarding document (@iansu)
Try to get a hold of Jack (@bugzpodder) and get him back on Discord (@Timer)Prototype template behaviour with dependencies, etc. (@mrmckeb)Create a GitHub Project for 3.0 (@iansu)Create a GitHub Project for issue triaging (@iansu)- Prototype webpack config freezing/warning (@Timer)
Set up CODEOWNERS (@iansu)
Action Items
- Inquire about getting a .dev domain name (@iansu)
- Follow up with Facebook designer about logo (@iansu)
- Talk to Eric Nakagawa about own GitHub org/Open Collective (@iansu)
- Make roadmap issue v3 (@iansu)
- Look into enabling canary releases (@ianschmitz)
- Talk to Storybook about peer dependencies (@mrmckeb)
- Create PR for typescript-eslint (@ianschmitz & @mrmckeb)
- Look into readiness of babel-plugin-optimize-react (@gaearon)
- Follow up on jsconfig PR (@mrmckeb)
- Follow up on Azure DevOps (@gaearon & @ianschmitz)
- Remove Node 11 from Travis config (@iansu)
- Remove AppVeyor config (@iansu)
- Revert CSS sourcemaps (@bugzpodder)
- Release 2.1.6 (@iansu)
- Improve labels (@iansu)
- Post PR process on Discord (@iansu)
- Automate docs deploy (@iansu)
- Document triaging process (@iansu)
- Document PR process (@iansu)
- Create maintainer onboarding document (@iansu)
- Look into new GitHub issue templates
- Continue investigating babel-preset-react-app issue
- Find a way to store and use responses to common issues (@iansu)
- Add a "Troubleshooting" section to the docs for common install issues
Details
February 20, 2019 10:00am Pacific
https://www.timeanddate.com/worldclock/fixedtime.html?msg=Create+React+App+maintainers+meeting&iso=20190220T18&p1=1440
Metadata
Metadata
Assignees
Labels
No labels