Add headings to all informational & dialog views

robertrossmann · robertrossmann · commit de16f7d69707 · 2019-02-01T10:28:33.000+01:00
diff --git a/lib/views/git-tab-view.js b/lib/views/git-tab-view.js
@@ -90,7 +90,7 @@ export default class GitTabView extends React.Component {
         <div className="github-Git is-empty" tabIndex="-1" ref={this.props.refRoot.setter}>
           <div ref="noRepoMessage" className="github-Git too-many-changes">
             <div className="github-Git-LargeIcon icon icon-diff" />
-            <h3>Too many changes</h3>
+            <h1>Too many changes</h1>
             <div className="initialize-repo-description">
               The repository at <strong>{this.props.workingDirectoryPath}</strong> has too many changed files
               to display in Atom. Ensure that you have set up an appropriate <code>.gitignore</code> file.
@@ -104,7 +104,7 @@ export default class GitTabView extends React.Component {
         <div className="github-Git is-empty" tabIndex="-1" ref={this.props.refRoot.setter}>
           <div ref="noRepoMessage" className="github-Git unsupported-directory">
             <div className="github-Git-LargeIcon icon icon-alert" />
-            <h3>Unsupported directory</h3>
+            <h1>Unsupported directory</h1>
             <div className="initialize-repo-description">
               Atom does not support managing Git repositories in your home or root directories.
             </div>
@@ -125,6 +125,7 @@ export default class GitTabView extends React.Component {
         <div className="github-Git is-empty" tabIndex="-1" ref={this.props.refRoot.setter}>
           <div ref="noRepoMessage" className="github-Git no-repository">
             <div className="github-Git-LargeIcon icon icon-repo" />
+            <h1>Create Repository</h1>
             <div className="initialize-repo-description">{message}</div>
             <button onClick={this.initializeRepo} disabled={inProgress} className="btn btn-primary">
               {inProgress ? 'Creating repository...' : 'Create repository'}
diff --git a/lib/views/github-login-view.js b/lib/views/github-login-view.js
@@ -48,6 +48,7 @@ export default class GithubLoginView extends React.Component {
     return (
       <div className="github-GithubLoginView-Subview">
         <div className="github-GitHub-LargeIcon icon icon-mark-github" />
+        <h1>Log in to GitHub</h1>
         {this.props.children}
         <button onClick={this.handleLoginClick} className="btn btn-primary icon icon-octoface">
           Login
@@ -60,6 +61,7 @@ export default class GithubLoginView extends React.Component {
     return (
       <form className="github-GithubLoginView-Subview" onSubmit={this.handleSubmitToken}>
         <div className="github-GitHub-LargeIcon icon icon-mark-github" />
+        <h1>Enter Token</h1>
         <ol>
           <li>Visit <a href="https://github.atom.io/login">github.atom.io/login</a> to generate
           an authentication token.</li>
diff --git a/lib/views/github-tab-view.js b/lib/views/github-tab-view.js
@@ -82,6 +82,7 @@ export default class GitHubTabView extends React.Component {
     return (
       <div className="github-GitHub-noRemotes">
         <div className="github-GitHub-LargeIcon icon icon-mark-github" />
+        <h1>No Remotes</h1>
         <div className="initialize-repo-description">
           <span>This repository does not have any remotes hosted at GitHub.com.</span>
         </div>
diff --git a/lib/views/remote-selector-view.js b/lib/views/remote-selector-view.js
@@ -16,6 +16,7 @@ export default class RemoteSelectorView extends React.Component {
     return (
       <div className="github-RemoteSelector">
         <div className="github-GitHub-LargeIcon icon icon-mirror" />
+        <h1>Multiple Remotes</h1>
         <div className="initialize-repo-description">
           <span>This repository has multiple remotes hosted at GitHub.com.
           Select a remote to see pull requests associated
diff --git a/styles/git-tab.less b/styles/git-tab.less
@@ -34,6 +34,10 @@
       margin: @component-padding 0;
     }
 
+    h1 {
+      margin-bottom: @component-padding * 3;
+    }
+
     button {
       overflow: hidden;
       text-overflow: ellipsis;
diff --git a/styles/github-login-view.less b/styles/github-login-view.less
@@ -16,6 +16,10 @@
       margin: @component-padding 0;
     }
 
+    h1 {
+      margin-bottom: @component-padding * 3;
+    }
+
     button {
       width: 100%;
       overflow: hidden;
diff --git a/styles/github-tab.less b/styles/github-tab.less
@@ -33,6 +33,10 @@
     > * {
       margin: @component-padding 0;
     }
+
+    h1 {
+      margin-bottom: @component-padding * 3;
+    }
   }
 
   .github-RemoteSelector {

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,10 @@`
`33`	`33`	`> * {`
`34`	`34`	`margin: @component-padding 0;`
`35`	`35`	`}`
	`36`	`+`
	`37`	`+ h1 {`
	`38`	`+ margin-bottom: @component-padding * 3;`
	`39`	`+ }`
`36`	`40`	`}`
`37`	`41`
`38`	`42`	`.github-RemoteSelector {`