Support PHP_REDIS_IGBINARY (Windows) #68
Conversation
Copy the headers to the root dir of the extension, where the redis extension tries to find them
|
Oh. I forgot about redis. Linux builds (config.m4) would still be broken (EDIT: oh, you mentioned that it was windows only). I also don't see a clear reason for data structures and macros and EDIT: Also, you assume that igbinary has phpconfig called before redis is built... Not familiar enough with windows to know if that's always the case. The most convenient way would be to create a fake igbinary/igbinary.h , which exposes the "public" APIs of igbinary (igbinary_serialize and igbinary_unserialize (unserializing to a zval* in php7 or zval** in php5)), so that extensions continued to work #if PHP_MAJOR_VERSION == 5
#include "igbinary/src/php5/igbinary_api.h"
#elsif PHP_MAJOR_VERSION == 7
#include "igbinary/src/php7/igbinary_api.h"
#else
#error "Unsupported php version"
#endif |
|
Anyway, I have time to do that. |
|
The redis build issues should be fixed in #69 , open an issue with output of |
Copy the headers to the root dir of the extension, where the redis extension tries to find them.
With this patch the compile command for php_redis.dll will be: