Support PHP_REDIS_IGBINARY (All platforms) #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config.m4: Use the command PHP_INSTALL_HEADERS to install headers globally in
ext/igbinary in the php installation directory.
(Aside: If it wasn't already installed, extensions could search for it in
pecl/igbinary as well, like this does for APCU?)
TODO: test in the Windows VM
config.w32: Use PHP_INSTALL_HEADERS to also include igbinary.h, which
just includes src/php{$PHP_MAJOR_VERSION}/igbinary.h
src/php*/igbinary.h: Make this into a standalone file.
Remove the dependency on the second file for declaring bool
- That may conflict with other extensions if those also declared bool.
Tested in php7.1
|
Tested on the windows VM, created phpredis/phpredis#917 for windows builds. |
|
Tested with PHP 7.0.10RC1 x64 nts: PHP_REDIS_IGBINARY is supported. |
|
Tested in all 4 variants of PHP 7.0.10RC1 and PHP 7.1.0 beta2. OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.m4: Use the command PHP_INSTALL_HEADERS to install headers globally in
ext/igbinary in the php installation directory.
(Aside: If it wasn't already installed, extensions could search for it in
pecl/igbinary as well, like this does for APCU?)
TODO: test in the Windows VM
config.w32: Use PHP_INSTALL_HEADERS to also include igbinary.h, which
just includes src/php{$PHP_MAJOR_VERSION}/igbinary.h
src/php*/igbinary.h: Make this into a standalone file.
Remove the dependency on the second file for declaring bool
Tested in php7.1