Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Record.prototype.filter: confusing behaviour #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andreypopp opened this issue Nov 27, 2014 · 6 comments
Closed

Record.prototype.filter: confusing behaviour #220

andreypopp opened this issue Nov 27, 2014 · 6 comments

Comments

@andreypopp
Copy link 

> var Immutable = require('immutable')
undefined
> var R = Immutable.Record({x: null, y: null})
undefined
> var r = new R()
undefined
> r.filter(function(v) { return v !== null; });
undefined

Accidentally stumbled upon this, though I understand that filter probably doesn't make sense for Record at all.
@leebyron
Copy link
Collaborator

Thanks for highlighting this. The correct fix is probably to make sure filter (and related methods) aren't methods of Record

@andreypopp andreypopp mentioned this issue Dec 30, 2014
Closed
@andreypopp andreypopp mentioned this issue Mar 25, 2015
Closed
@grav
Copy link

grav commented Apr 23, 2015

Or that it returns a type Map?

@leebyron leebyron mentioned this issue Jun 18, 2015
Closed
@ghost
Copy link

ghost commented Aug 4, 2015

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

@corbt corbt mentioned this issue Dec 29, 2015
Merged
@jimitndiaye
Copy link

This issue is still occurring in v3.8.1

@srghma
Copy link

srghma commented Nov 22, 2016

Even warnings didnt show in v3.8.1

@srghma srghma mentioned this issue Nov 22, 2016
Closed
@leebyron
Copy link
Collaborator

leebyron commented Mar 8, 2017

Merging into #505

@leebyron leebyron closed this as completed Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@andreypopp @leebyron @grav @jimitndiaye @srghma