Adapt to changes to firedrake-check #946
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like it worked anyhow? 🙂 Is this good to merge? |
Looking at the logs it is failing in the expected way but for some reason that error isn't being propagated to the outer process. This might be an artefact of the |
|
Uh-oh, nice catch! IIUC, the lack of nonzero exit code is a bug on your end? |
I can easily believe that. I think it's likely that that will be fixed when this change lands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just merged some tweaks to
firedrake-checkthat will break your current workflow as soon as we make another release. I've done what I think should be the necessary changes.This will not work until we make another release and rebuild our containers.