Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 59bbb86

Browse files
committed
python: Changed chart tests to print running the simulations and always do the chart exporting.
Silently running a lot of simulations is confusing for the user. Silently not running the chart tests if one of the simulations fail is also very confusing.
1 parent 2499758 commit 59bbb86

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

python/inet/test/chart.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,8 @@ def __init__(self, multiple_simulation_tasks=None, name="chart test", multiple_t
6262
self.multiple_simulation_tasks = multiple_simulation_tasks
6363

6464
def run_protected(self, **kwargs):
65-
multiple_simulation_task_results = self.multiple_simulation_tasks.run_protected(output_stream=io.StringIO(), **kwargs)
66-
if multiple_simulation_task_results.result != "DONE":
67-
return self.multiple_task_results_class(self, result=multiple_simulation_task_results.result)
68-
else:
69-
return super().run_protected(**kwargs)
65+
multiple_simulation_task_results = self.multiple_simulation_tasks.run_protected(**kwargs)
66+
return super().run_protected(**kwargs)
7067

7168
def get_chart_test_tasks(simulation_project=default_project, run_simulations=True, filter=None, working_directory_filter=None, pool_class=multiprocessing.Pool, **kwargs):
7269
test_tasks = []

0 commit comments

Comments
 (0)