-
Notifications
You must be signed in to change notification settings - Fork 450
Closed as not planned
Labels
bugSomething isn't workingSomething isn't workingfunctionalIssues that require a code changeIssues that require a code changejiraThis triggers jira syncThis triggers jira syncstale
Description
Describe the bug
When ilab receives a list in a specific way, for example when ilab model train receives the lora_target_modules parameter, Click performs some magic under the hood which automatically converts the list into a tuple.
Oftentimes though this is not behavior which we want, since we naturally expect the specific list data structure
under the hood in many of our type signatures. For example leading to the error which was solved by this PR: #2026
/opt/app-root/lib64/python3.11/site-packages/pydantic/main.py:364: UserWarning: Pydantic serializer warnings:
Expected `list[str]` but got `tuple` - serialized value may not be as expected
return self.__pydantic_serializer__.to_python(
To Reproduce
Steps to reproduce the behavior:
- Check out any commit prior to when Enforce list type for lora-target-modules #2026 was merged (if it's merged by then)
- Run
ilab model train
Expected behavior
No warning message appears
Device Info (please complete the following information):
- Hardware Specs: [e.g. Apple M2 Pro Chip, 16 GB Memory, etc.]
- OS Version: [e.g. Mac OS 14.4.1, Fedora Linux 40]
- Python Version: [output of
python --version] - InstructLab Version: [output of
ilab --version]
Additional context
booxter and junaruga
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingfunctionalIssues that require a code changeIssues that require a code changejiraThis triggers jira syncThis triggers jira syncstale