Thanks to visit codestin.com
Credit goes to github.com

Skip to content

NeoDevice Serial number range check #156

@pierreluctg

Description

@pierreluctg

Recent commit, 0ebf147#diff-31465b92e05bd43db3ca2ff1c3debf55f46d1d055b86d6dc6b1f58d125fb3262 changed the NeoDevice Serial number range check.

However, the code comment do not match the code (int value).
On 0ebf147#diff-31465b92e05bd43db3ca2ff1c3debf55f46d1d055b86d6dc6b1f58d125fb3262R146, AA0000 was changed to A00000

and on 0ebf147#diff-31465b92e05bd43db3ca2ff1c3debf55f46d1d055b86d6dc6b1f58d125fb3262R149, 621457920 was changed to 16796160.

If 16796160 is the right int value, the comment on line 146 should be A0000 and not A00000 or else the comment is correct and the int value should be 604661760.

Based on https://github.com/intrepidcs/libicsneo/blob/018f1fac8e42ca6789235d4991e41bb3083b929f/device/device.cpp#L36, the int value (16796160) is correct and there a typo in the comment.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions