fix: correct default config to closely match eslint's camelcase

bradzacher · bradzacher · commit 409a6167838c · 2019-12-19T11:35:13.000+10:30
diff --git a/packages/eslint-plugin/docs/rules/naming-convention.md b/packages/eslint-plugin/docs/rules/naming-convention.md
@@ -45,23 +45,15 @@ const defaultOptions: Options = [
   {
     selector: 'default',
     format: ['camelCase'],
+    leadingUnderscore: 'allow',
+    trailingUnderscore: 'allow',
   },
 
   {
     selector: 'variable',
     format: ['camelCase', 'UPPER_CASE'],
-  },
-  {
-    selector: 'parameter',
-    format: ['camelCase'],
     leadingUnderscore: 'allow',
-  },
-
-  {
-    selector: 'memberLike',
-    modifiers: ['private'],
-    format: ['camelCase'],
-    leadingUnderscore: 'require',
+    trailingUnderscore: 'allow',
   },
 
   {
diff --git a/packages/eslint-plugin/src/rules/naming-convention.ts b/packages/eslint-plugin/src/rules/naming-convention.ts
@@ -274,25 +274,21 @@ const SCHEMA: JSONSchema.JSONSchema4 = {
 
 // #endregion Schema Config
 
+// This essentially mirrors eslint's camelcase rule
+// note that that rule ignores leading and trailing underscores and only checks those in the middle of a variable name
 const defaultCamelCaseAllTheThingsConfig: Options = [
   {
     selector: 'default',
     format: ['camelCase'],
+    leadingUnderscore: 'allow',
+    trailingUnderscore: 'allow',
   },
 
   {
     selector: 'variable',
     format: ['camelCase', 'UPPER_CASE'],
-  },
-  {
-    selector: 'parameter',
-    format: ['camelCase'],
     leadingUnderscore: 'allow',
-  },
-
-  {
-    selector: 'memberLike',
-    format: ['camelCase'],
+    trailingUnderscore: 'allow',
   },
 
   {
