Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(SystemBars): Skipping margin manipulation when on a fixed WebView #8309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theproducer merged 9 commits into from
Jan 22, 2026
+30 −11
Merged

fix(SystemBars): Skipping margin manipulation when on a fixed WebView #8309

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
593e53d
fix(SystemBars): Pass through insets if window not focused
theproducer Jan 16, 2026
6c97fea
Also check if the activity has a splash screen showing
theproducer Jan 16, 2026
391480a
fmt
theproducer Jan 19, 2026
8d598d4
Checking if view is being shown
theproducer Jan 19, 2026
c487c5c
add check for webview version
theproducer Jan 20, 2026
0e19f66
Skipping margin manipulation when on a fixed webview
theproducer Jan 20, 2026
d9f1469
fmt
theproducer Jan 20, 2026
8ca2829
Merge branch 'main' into fix/RMET-4940
theproducer Jan 20, 2026
9ce91eb
fixing broken webview version number
theproducer Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 30 additions & 11 deletions android/capacitor/src/main/java/com/getcapacitor/plugin/SystemBars.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.getcapacitor.plugin;

import android.content.pm.PackageInfo;
import android.content.res.Configuration;
import android.os.Build;
import android.view.View;
Expand All @@ -12,6 +13,7 @@
import androidx.core.view.WindowCompat;
import androidx.core.view.WindowInsetsCompat;
import androidx.core.view.WindowInsetsControllerCompat;
import androidx.webkit.WebViewCompat;
import com.getcapacitor.Plugin;
import com.getcapacitor.PluginCall;
import com.getcapacitor.PluginMethod;
Expand Down Expand Up @@ -145,6 +147,9 @@ public void onDOMReady() {

private Insets calcSafeAreaInsets(WindowInsetsCompat insets) {
Insets safeArea = insets.getInsets(WindowInsetsCompat.Type.systemBars() | WindowInsetsCompat.Type.displayCutout());
if (insets.isVisible(WindowInsetsCompat.Type.ime())) {
return Insets.of(safeArea.left, safeArea.top, safeArea.right, 0);
}
return Insets.of(safeArea.left, safeArea.top, safeArea.right, safeArea.bottom);
}

Expand All @@ -162,21 +167,25 @@ private void initSafeAreaInsets() {
private void initWindowInsetsListener() {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.VANILLA_ICE_CREAM && insetHandlingEnabled) {
ViewCompat.setOnApplyWindowInsetsListener((View) getBridge().getWebView().getParent(), (v, insets) -> {
boolean hasBrokenWebViewVersion = getWebViewMajorVersion() <= 139;

if (hasViewportCover) {
Insets safeAreaInsets = calcSafeAreaInsets(insets);
boolean keyboardVisible = insets.isVisible(WindowInsetsCompat.Type.ime());

if (keyboardVisible) {
safeAreaInsets = Insets.of(safeAreaInsets.left, safeAreaInsets.top, safeAreaInsets.right, 0);
injectSafeAreaCSS(safeAreaInsets.top, safeAreaInsets.right, safeAreaInsets.bottom, safeAreaInsets.left);
}

Insets imeInsets = insets.getInsets(WindowInsetsCompat.Type.ime());
setViewMargins(v, Insets.of(0, 0, 0, imeInsets.bottom));
} else {
setViewMargins(v, Insets.NONE);
if (hasBrokenWebViewVersion) {
if (hasViewportCover && v.hasWindowFocus() && v.isShown()) {
boolean keyboardVisible = insets.isVisible(WindowInsetsCompat.Type.ime());
if (keyboardVisible) {
Insets imeInsets = insets.getInsets(WindowInsetsCompat.Type.ime());
setViewMargins(v, Insets.of(0, 0, 0, imeInsets.bottom));
} else {
setViewMargins(v, Insets.NONE);
}

return WindowInsetsCompat.CONSUMED;
}

injectSafeAreaCSS(safeAreaInsets.top, safeAreaInsets.right, safeAreaInsets.bottom, safeAreaInsets.left);
return WindowInsetsCompat.CONSUMED;
}

return insets;
Expand Down Expand Up @@ -272,4 +281,14 @@ private String getStyleForTheme() {
}
return STYLE_DARK;
}

private Integer getWebViewMajorVersion() {
PackageInfo info = WebViewCompat.getCurrentWebViewPackage(getContext());
if (info != null && info.versionName != null) {
String[] versionSegments = info.versionName.split("\\.");
return Integer.valueOf(versionSegments[0]);
}

return 0;
}
}