Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit dc09481

Browse files
VectorizedVectorized
authored
🥢 Nit comments (argotorg#768)
1 parent 13c5acf commit dc09481

File tree

5 files changed

+14
-13
lines changed

5 files changed

+14
-13
lines changed

‎.gas-snapshot‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -221,21 +221,21 @@ ERC2981Test:testRoyaltyOverflowCheckDifferential(uint256,uint256) (runs: 256, μ
221221
ERC2981Test:testSetAndGetRoyaltyInfo(uint256) (runs: 256, μ: 107649, ~: 104801)
222222
ERC2981Test:test__codesize() (gas: 8419)
223223
ERC4337FactoryTest:testCreateAccountRepeatedDeployment() (gas: 149757)
224-
ERC4337FactoryTest:testCreateAccountRepeatedDeployment(uint256) (runs: 256, μ: 171765, ~: 171617)
225-
ERC4337FactoryTest:testDeployDeterministic(uint256) (runs: 256, μ: 135990, ~: 139900)
224+
ERC4337FactoryTest:testCreateAccountRepeatedDeployment(uint256) (runs: 256, μ: 171755, ~: 171681)
225+
ERC4337FactoryTest:testDeployDeterministic(uint256) (runs: 256, μ: 134021, ~: 139900)
226226
ERC4337FactoryTest:test__codesize() (gas: 13520)
227227
ERC4337Test:testCdFallback() (gas: 443989)
228228
ERC4337Test:testCdFallback2() (gas: 1140699)
229229
ERC4337Test:testDelegateExecute() (gas: 369570)
230-
ERC4337Test:testDelegateExecute(uint256) (runs: 256, μ: 355802, ~: 344555)
230+
ERC4337Test:testDelegateExecute(uint256) (runs: 256, μ: 355322, ~: 344555)
231231
ERC4337Test:testDelegateExecuteRevertsIfOwnerSlotValueChanged() (gas: 319282)
232232
ERC4337Test:testDepositFunctions() (gas: 502955)
233233
ERC4337Test:testDirectStorage() (gas: 70413)
234234
ERC4337Test:testDisableInitializerForImplementation() (gas: 1177324)
235235
ERC4337Test:testETHReceived() (gas: 16584)
236236
ERC4337Test:testExecute() (gas: 382786)
237237
ERC4337Test:testExecuteBatch() (gas: 692605)
238-
ERC4337Test:testExecuteBatch(uint256) (runs: 256, μ: 507443, ~: 368207)
238+
ERC4337Test:testExecuteBatch(uint256) (runs: 256, μ: 526856, ~: 368483)
239239
ERC4337Test:testInitializer() (gas: 285192)
240240
ERC4337Test:testIsValidSignature() (gas: 111663)
241241
ERC4337Test:testIsValidSignaturePersonalSign() (gas: 96270)
@@ -266,18 +266,18 @@ ERC4626Test:testWithdrawWithNotEnoughUnderlyingAmountReverts() (gas: 144074)
266266
ERC4626Test:testWithdrawZero() (gas: 52807)
267267
ERC4626Test:test__codesize() (gas: 41067)
268268
ERC6551Test:testCdFallback() (gas: 894557)
269-
ERC6551Test:testDeployERC6551(uint256) (runs: 256, μ: 171349, ~: 168731)
269+
ERC6551Test:testDeployERC6551(uint256) (runs: 256, μ: 171249, ~: 168738)
270270
ERC6551Test:testDeployERC6551Proxy() (gas: 80751)
271271
ERC6551Test:testExecute() (gas: 507855)
272272
ERC6551Test:testExecuteBatch() (gas: 816977)
273-
ERC6551Test:testExecuteBatch(uint256) (runs: 256, μ: 589730, ~: 483186)
273+
ERC6551Test:testExecuteBatch(uint256) (runs: 256, μ: 611168, ~: 483186)
274274
ERC6551Test:testInitializeERC6551ProxyImplementation() (gas: 189801)
275275
ERC6551Test:testIsValidSignature() (gas: 187612)
276276
ERC6551Test:testOnERC1155BatchReceived() (gas: 1526542)
277277
ERC6551Test:testOnERC1155Received() (gas: 1523898)
278278
ERC6551Test:testOnERC721Received() (gas: 1447973)
279279
ERC6551Test:testOnERC721ReceivedCycles() (gas: 1711044)
280-
ERC6551Test:testOnERC721ReceivedCyclesWithDifferentChainIds(uint256) (runs: 256, μ: 448808, ~: 454378)
280+
ERC6551Test:testOnERC721ReceivedCyclesWithDifferentChainIds(uint256) (runs: 256, μ: 448611, ~: 454014)
281281
ERC6551Test:testSupportsInterface() (gas: 169387)
282282
ERC6551Test:testUpgrade() (gas: 1154845)
283283
ERC6551Test:test__codesize() (gas: 47762)

‎src/accounts/ERC4337.sol‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,18 @@ import {SignatureCheckerLib, ERC1271} from "../accounts/ERC1271.sol";
1111
/// @author Solady (https://github.com/vectorized/solady/blob/main/src/accounts/ERC4337.sol)
1212
/// @author Infinitism (https://github.com/eth-infinitism/account-abstraction/blob/develop/contracts/samples/SimpleAccount.sol)
1313
///
14-
/// Recommended usage:
14+
/// @dev Recommended usage:
1515
/// 1. Deploy the ERC4337 as an implementation contract, and verify it on Etherscan.
1616
/// 2. Create a factory that uses `LibClone.deployERC1967` or
1717
/// `LibClone.deployDeterministicERC1967` to clone the implementation.
1818
/// See: `ERC4337Factory.sol`.
1919
///
20-
/// Note: ERC4337 is a very complicated standard with many potential gotchas.
20+
/// Note:
21+
/// ERC4337 is a very complicated standard with many potential gotchas.
2122
/// Usually, ERC4337 account implementations are developed by companies with ample funds
2223
/// for security reviews. This implementation is intended to serve as a base reference
2324
/// for smart account developers working in such companies. If you are using this
24-
/// implementation, please do get one or more security review before deployment.
25+
/// implementation, please do get one or more security reviews before deployment.
2526
abstract contract ERC4337 is Ownable, UUPSUpgradeable, Receiver, ERC1271 {
2627
/*´:°•.°+.*•´.*:˚.°*.˚•´.°:°•.°•.*•´.*:˚.°*.˚•´.°:°•.°+.*•´.*:*/
2728
/* STRUCTS */

‎src/accounts/ERC4337Factory.sol‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {LibClone} from "../utils/LibClone.sol";
66
/// @notice Simple ERC4337 account factory implementation.
77
/// @author Solady (https://github.com/vectorized/solady/blob/main/src/accounts/ERC4337Factory.sol)
88
///
9-
/// Note:
9+
/// @dev Note:
1010
/// - Unlike the ERC1967Factory, this factory does NOT store any admin info on the factory itself.
1111
/// The deployed ERC4337 accounts are minimal ERC1967 proxies to an ERC4337 implementation.
1212
/// The proxy bytecode does NOT contain any upgrading logic.

‎src/accounts/ERC6551.sol‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {UUPSUpgradeable} from "../utils/UUPSUpgradeable.sol";
1010
/// @author Solady (https://github.com/vectorized/solady/blob/main/src/accounts/ERC6551.sol)
1111
/// @author ERC6551 team (https://github.com/erc6551/reference/blob/main/src/examples/upgradeable/ERC6551AccountUpgradeable.sol)
1212
///
13-
/// Recommended usage (regular):
13+
/// @dev Recommended usage (regular):
1414
/// 1. Deploy the ERC6551 as an implementation contract, and verify it on Etherscan.
1515
/// 2. Use the canonical ERC6551Registry to deploy a clone to the ERC6551 implementation.
1616
/// The UUPSUpgradeable functions will simply become no-ops.

‎src/accounts/ERC6551Proxy.sol‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ pragma solidity ^0.8.4;
55
/// @author Solady (https://github.com/vectorized/solady/blob/main/src/accounts/ERC6551Proxy.sol)
66
/// @author ERC6551 team (https://github.com/erc6551/reference/blob/main/src/examples/upgradeable/ERC6551AccountProxy.sol)
77
///
8-
/// Note: This relay proxy is required for upgradeable ERC6551 accounts.
8+
/// @dev Note: This relay proxy is required for upgradeable ERC6551 accounts.
99
///
1010
/// ERC6551 clone -> ERC6551Proxy (relay) -> ERC6551 account implementation.
1111
///

0 commit comments

Comments
 (0)