Merge pull request #12678 from rushabh-v/pl-ipdoctest

Carreau · web-flow · commit 6bef27ab7384 · 2020-10-27T10:24:08.000-07:00
use pathlib in testing/plugin/ipdoctest.py
diff --git a/IPython/testing/plugin/ipdoctest.py b/IPython/testing/plugin/ipdoctest.py
@@ -33,6 +33,8 @@
 
 from inspect import getmodule
 
+from pathlib import Path, PurePath
+
 # We are overriding the default doctest runner, so we need to import a few
 # things from doctest directly
 from doctest import (REPORTING_FLAGS, REPORT_ONLY_FIRST_FAILURE,
@@ -687,9 +689,8 @@ def loadTestsFromFile(self, filename):
                 yield t
         else:
             if self.extension and anyp(filename.endswith, self.extension):
-                name = os.path.basename(filename)
-                with open(filename) as dh:
-                    doc = dh.read()
+                name = PurePath(filename).name
+                doc = Path(filename).read_text()
                 test = self.parser.get_doctest(
                     doc, globs={'__file__': filename}, name=name,
                     filename=filename, lineno=0)
