trust-exported-notebooks

Darshan808 · Darshan808 · commit ba29858fabca · 2025-09-20T17:41:51.000+05:45
diff --git a/IPython/core/magics/basic.py b/IPython/core/magics/basic.py
@@ -559,6 +559,7 @@ def notebook(self, s):
         outfname = os.path.expanduser(args.filename)
 
         from nbformat import write, v4
+        from nbformat.sign import NotebookNotary
 
         cells = []
         hist = list(self.shell.history_manager.get_range())
@@ -629,6 +630,9 @@ def notebook(self, s):
                 },
             },
         )
+        # Sign the notebook to make it trusted
+        notary = NotebookNotary()
+        notary.sign(nb)
         with io.open(outfname, "w", encoding="utf-8") as f:
             write(nb, f, version=4)
 
diff --git a/tests/test_magic.py b/tests/test_magic.py
@@ -1000,6 +1000,7 @@ def test_extension():
 
 def test_notebook_export_json():
     pytest.importorskip("nbformat")
+    from nbformat import read, sign
     _ip = get_ipython()
     _ip.history_manager.reset()  # Clear any existing history.
     cmds = ["a=1", "def b():\n  return a**2", "print('noël, été', b())"]
@@ -1010,6 +1011,7 @@ def test_notebook_export_json():
         _ip.run_line_magic("notebook", "%s" % outfile)
         with open(outfile) as f:
             exported = json.load(f)
+        nb = read(outfile, as_version=4)
 
     # check metadata
     language_info = exported["metadata"]["language_info"]
@@ -1020,6 +1022,10 @@ def test_notebook_export_json():
     kernelspec = exported["metadata"]["kernelspec"]
     assert kernelspec["language"] == "python"
 
+    # Check if notebook is trusted
+    notary = sign.NotebookNotary()
+    is_trusted = notary.check_signature(nb)
+    assert is_trusted, "Exported notebook should be trusted"
 
 def test_notebook_export_json_with_output():
     """Tests if notebook export correctly captures outputs, errors, display outputs, and stream outputs."""
