Merge pull request #13679 from eendebakpt/prevent_popup_windows

Carreau · web-flow · commit c24bf50f35d8 · 2022-08-30T11:21:01.000+02:00
Prevent popup windows during execution of latex_to_png_dvipng
diff --git a/IPython/lib/latextools.py b/IPython/lib/latextools.py
@@ -144,6 +144,13 @@ def latex_to_png_dvipng(s, wrap, color='Black', scale=1.0):
         find_cmd('dvipng')
     except FindCmdError:
         return None
+
+    startupinfo = None
+    if os.name == "nt":
+        # prevent popup-windows
+        startupinfo = subprocess.STARTUPINFO()
+        startupinfo.dwFlags |= subprocess.STARTF_USESHOWWINDOW
+
     try:
         workdir = Path(tempfile.mkdtemp())
         tmpfile = "tmp.tex"
@@ -156,7 +163,11 @@ def latex_to_png_dvipng(s, wrap, color='Black', scale=1.0):
         with open(os.devnull, 'wb') as devnull:
             subprocess.check_call(
                 ["latex", "-halt-on-error", "-interaction", "batchmode", tmpfile],
-                cwd=workdir, stdout=devnull, stderr=devnull)
+                cwd=workdir,
+                stdout=devnull,
+                stderr=devnull,
+                startupinfo=startupinfo,
+            )
 
             resolution = round(150*scale)
             subprocess.check_call(
@@ -179,6 +190,7 @@ def latex_to_png_dvipng(s, wrap, color='Black', scale=1.0):
                 cwd=workdir,
                 stdout=devnull,
                 stderr=devnull,
+                startupinfo=startupinfo,
             )
 
         with workdir.joinpath(outfile).open("rb") as f:
diff --git a/docs/source/whatsnew/pr/latex-generation-no-popup-window.rst b/docs/source/whatsnew/pr/latex-generation-no-popup-window.rst
@@ -0,0 +1,5 @@
+No popup in window for latex generation
+=======================================
+
+When generating latex (e.g. via `_latex_repr_`) no popup window is shows under Windows.
+
