fix-subscript-assignment

Darshan808 · Darshan808 · commit e874d03fd906 · 2025-10-26T21:57:03.000+05:45
diff --git a/IPython/core/guarded_eval.py b/IPython/core/guarded_eval.py
@@ -560,6 +560,7 @@ def _validate_policy_overrides(
 def _handle_assign(node: ast.Assign, context: EvaluationContext):
     value = eval_node(node.value, context)
     transient_locals = context.transient_locals
+    policy = get_policy(context)
     for target in node.targets:
         if isinstance(target, (ast.Tuple, ast.List)):
             # Handle unpacking assignment
@@ -586,6 +587,22 @@ def _handle_assign(node: ast.Assign, context: EvaluationContext):
                     transient_locals[targets[i].id] = values[
                         len(values) - (len(targets) - i)
                     ]
+        elif isinstance(target, ast.Subscript):
+            if isinstance(target.value, ast.Name):
+                name = target.value.id
+                container = transient_locals.get(name)
+                if container is None:
+                    container = context.locals.get(name)
+                if container is None:
+                    container = context.globals.get(name)
+                if container is None:
+                    raise NameError(
+                        f"{name} not found in locals, globals, nor builtins"
+                    )
+
+                key = eval_node(target.slice, context)
+                if policy.can_call(container.__setitem__):
+                    container[key] = value
         else:
             transient_locals[target.id] = value
     return None
@@ -1118,6 +1135,7 @@ def _list_methods(cls, source=None):
     *_list_methods(collections.Counter, dict_non_mutating_methods),
     collections.Counter.elements,
     collections.Counter.most_common,
+    dict.__setitem__,
 }
 
 BUILTIN_GETATTR: set[MayHaveGetattr] = {
diff --git a/tests/test_completer.py b/tests/test_completer.py
@@ -2096,6 +2096,26 @@ def _(expected):
             ),
             "as_integer_ratio",
         ],
+        [
+            "\n".join(
+                [
+                    "num = {1: 'one'}",
+                    "num[2] = 'two'",
+                    "num.",
+                ]
+            ),
+            "keys",
+        ],
+        [
+            "\n".join(
+                [
+                    "test = {1: 'one'}",
+                    "test[2] = ['two']",
+                    "test[2].",
+                ]
+            ),
+            "append",
+        ],
     ],
 )
 def test_undefined_variables(use_jedi, evaluation, code, insert_text):
