Fix unicode printing on windows in tests.

Carreau · Carreau · commit fe2cad86f79e · 2025-02-23T18:26:35.000+01:00
and a few other fixes.
diff --git a/IPython/core/interactiveshell.py b/IPython/core/interactiveshell.py
@@ -1002,7 +1002,7 @@ def banner(self):
     def show_banner(self, banner=None):
         if banner is None:
             banner = self.banner
-        sys.stdout.write(banner)
+        print(banner)
 
     #-------------------------------------------------------------------------
     # Things related to hooks
diff --git a/IPython/utils/tempdir.py b/IPython/utils/tempdir.py
@@ -10,7 +10,7 @@
 
 
 class NamedFileInTemporaryDirectory:
-    def __init__(self, filename, mode="w+b", bufsize=-1, add_to_syspath=False, **kwds):
+    def __init__(self, filename, mode, bufsize=-1, add_to_syspath=False, **kwds):
         """
         Open a file named `filename` in a temporary directory.
 
diff --git a/tests/test_display_2.py b/tests/test_display_2.py
@@ -347,7 +347,7 @@ def test_video_embedding():
     with pytest.raises(ValueError):
         v = display.Video(b"abc")
 
-    with NamedFileInTemporaryDirectory("test.mp4") as f:
+    with NamedFileInTemporaryDirectory("test.mp4", "wb") as f:
         f.write(b"abc")
         f.close()
 
diff --git a/tests/test_embed.py b/tests/test_embed.py
@@ -24,7 +24,7 @@
 # -----------------------------------------------------------------------------
 
 
-_sample_embed = b"""
+_sample_embed = """
 import IPython
 
 a = 3
@@ -36,12 +36,12 @@
 print('bye!')
 """
 
-_exit = b"exit\r"
+_exit = "exit\r"
 
 
 def test_ipython_embed():
     """test that `IPython.embed()` works"""
-    with NamedFileInTemporaryDirectory("file_with_embed.py") as f:
+    with NamedFileInTemporaryDirectory("file_with_embed.py", "w") as f:
         f.write(_sample_embed)
         f.flush()
         f.close()  # otherwise msft won't be able to read the file
@@ -57,12 +57,11 @@ def test_ipython_embed():
             stdin=subprocess.PIPE,
             stdout=subprocess.PIPE,
             stderr=subprocess.PIPE,
+            text=True,
+            encoding="UTF-8",
         )
-        out, err = p.communicate(_exit)
-        try:
-            std = out.decode("UTF-8", "replace")
-        except UnicodeDecodeError as e:
-            raise ValueError(f"Error decoding {out!r}") from e
+        std, err = p.communicate(_exit)
+        assert isinstance(std, str)
 
         assert p.returncode == 0, (p.returncode, std)
         assert "3 . 14" in std
diff --git a/tests/test_tempdir.py b/tests/test_tempdir.py
@@ -12,7 +12,7 @@
 
 
 def test_named_file_in_temporary_directory():
-    with NamedFileInTemporaryDirectory("filename") as file:
+    with NamedFileInTemporaryDirectory("filename", "wb") as file:
         name = file.name
         assert not file.closed
         assert Path(name).exists()
