The iopub behavior you described is more less the same as what I think it would be (actually I thought request id will be cleared after execute_reply). And output_finished message you suggested is the same as what I thought it should be for the first implementation (i.e., no thread support).

For the thread support, I am imagining doing something like the following in OutStream.flush():

def flush(self):
    data = self._buffer.getvalue()
    content = {u'name': self.name, u'data': data}
    parent_header = THREAD_HEADER_MAP[threading.current_thread()]
    self.session.send(
        self.pub_socket, u'stream', content=content,
        parent=parent_header, ident=self.topic)

Here THREAD_HEADER_MAP is a hypothetical dict which maps a thread object to the message header object. Then, you can use something like the following for thread target function to register the thread to this dict.

def target_wrapper(parent_header, real_target):
    THREAD_HEADER_MAP[threading.current_thread()] = parent_header
    try:
        real_target()
    finally:
        THREAD_HEADER_MAP.pop(threading.current_thread())
        for (thread, header) in THREAD_HEADER_MAP.items():
            if header == parent_header:
                break
        else:
            get_session().send(self.pub_socket, u'output_finished',
                              parent=parent_header)

(please imagine that THREAD_HEADER_MAP is a thread-safe dict)

Uh oh!

[Notebook] Clear kernel queue #2524

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions