potentially expensive but working history browsing

ivanov · ivanov · commit 895a6074effc · 2014-04-21T11:51:16.000-07:00
this fetches the current history's entire session on every execution.

It would be fairly easy to make this happen *only* after an initial
'cursor up' motion, and also chunk it to not grab the full thing.
diff --git a/README.md b/README.md
@@ -106,12 +106,15 @@ TODO / KNOWN ISSUES:
 
         [x] maybe i should hook into interp and just turn that into a no-op,
             that way i can keep the current (cheap) history as is?
+        
+        [ ] history saves only last input, make it work with all
 
         [ ] make history work *across* sessions, not just current one
 
         [ ] make multiline history work
 
         [ ] handle History.enabled = False case gracefully as well
+    
 
     [x] MUSTFIX: Python 3 compatability (all of my dependencies meet them)
 
@@ -295,3 +298,8 @@ TODO / KNOWN ISSUES:
     [ ] up-arrow shouldn't search for partial completion (since that won't work)
 
     [ ] cheap completion is broken again :(
+
+    [ ] non-ascii completion breaks bipython (yay unicode)
+
+    [ ] run completion for "import <tab>" since ipython supports that.
+
diff --git a/bipython/__init__.py b/bipython/__init__.py
@@ -430,6 +430,7 @@ def move_cursor_to_coords(self, *args):
     def keypress(self, size, key):
         if urwid.command_map[key] in ['cursor up', 'cursor down']:
             # Do not handle up/down arrow, leave them for the repl.
+            #sys.stderr.write("cursor keys")
             return key
 
         self._bpy_may_move_cursor = True
@@ -1049,6 +1050,7 @@ def cw(self):
         text = self.edit.get_edit_text()
         if pos != len(text):
             # Disable autocomplete if not at end of line, like cli does.
+            # XXX: I think we can make this compeltion work here -pi
             return
 
         # Stolen from cli. TODO: clean up and split out.
@@ -1497,6 +1499,7 @@ def push(self, s, insert_into_history=True):
         # Pretty blindly adapted from bpython.cli
         try:
             msg_id = self.send_ipython(s)
+            #self.rl_history.enter(s)
             if hasattr(repl.Repl, 'insert_into_history'):
                 # this is only in unreleased version of bpython
                 self.insert_into_history(s)
@@ -1580,7 +1583,7 @@ def prompt(self, more):
         # sitting above this prompt:
         self.current_output = None
         # XXX is this the right place?
-        self.rl_history.reset()
+        #self.rl_history.reset()
         # XXX what is s_hist?
 
         # We need the caption to use unicode as urwid normalizes later
@@ -1650,6 +1653,9 @@ def handle_input(self, event):
             self.main_loop.draw_screen()
             more = self.push(inp)
             self.prompt(more)
+            # XXX: fetching all history is expensive, but better than nothing
+            # for now
+            self.rl_history = IPythonHistory(self)
         elif event == 'ctrl d':
             # ctrl+d on an empty line exits, otherwise deletes
             if self.edit is not None:
@@ -1672,7 +1678,9 @@ def handle_input(self, event):
         elif urwid.command_map[event] == 'prev selectable':
             self.tab(True)
         elif event == 'esc':
-            self.clear_docstring() # why is this so slow?, ARGH!
+            self.ipython_get_doc('')
+            #self.clear_docstring() # why is this so slow?, ARGH!
+            # XXX: tab redraws really quickly
         else:
             self.echo(repr(event))
 
