Enforce python 2.4 or later; some other version-related cleanup

efiring · efiring · commit 019e303a2c98 · 2008-04-25T16:45:30.000Z
svn path=/trunk/matplotlib/; revision=5075
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,3 +1,6 @@
+2008-04-25 Enforce python >= 2.4; remove subprocess build - EF
+
+2008-04-25 Enforce the numpy requirement at build time - JDH
 
 2008-04-24 Make numpy 1.1 and python 2.3 required when importing
            matplotlib - EF
diff --git a/lib/matplotlib/__init__.py b/lib/matplotlib/__init__.py
@@ -95,9 +95,7 @@
 from rcsetup import validate_cairo_format
 
 major, minor1, minor2, s, tmp = sys.version_info
-_python23 = major>=2 and minor1>=3
-
-_havemath = _python23
+_python24 = major>=2 and minor1>=4
 
 try:
     import datetime
@@ -111,14 +109,14 @@
 #except ImportError: _have_pkg_resources = False
 #else: _have_pkg_resources = True
 
-if not _python23:
-    raise SystemExit('matplotlib requires Python 2.3 or later')
+if not _python24:
+    raise SystemExit('matplotlib requires Python 2.4 or later')
 
 import numpy
 nn = numpy.__version__.split('.')
 if not (int(nn[0]) >= 1 and int(nn[1]) >= 1):
     raise SystemExit(
-            'numpy >= 1.1 is required; you have %s' % numpy.__version__)
+            'numpy 1.1 or later is required; you have %s' % numpy.__version__)
 
 def is_string_like(obj):
     if hasattr(obj, 'shape'): return 0
diff --git a/setup.py b/setup.py
@@ -20,28 +20,15 @@
 import sys
 major, minor1, minor2, s, tmp = sys.version_info
 
-if major==2 and minor1<=3:
-    # setuptools monkeypatches distutils.core.Distribution to support
-    # package_data
-    try: import setuptools
-    except ImportError:
-        raise SystemExit("""\
-matplotlib requires setuptools for installation with python-2.3.  Visit:
-http://cheeseshop.python.org/pypi/setuptools
-for installation instructions for the proper version of setuptools for your
-system.  If this is your first time upgrading matplotlib with the new
-setuptools requirement, you must delete the old matplotlib install
-directory.""")
-
-if major==2 and minor1<3 or major<2:
-    raise SystemExit("""matplotlib requires Python 2.3 or later.""")
+if major==2 and minor1<4 or major<2:
+    raise SystemExit("""matplotlib requires Python 2.4 or later.""")
 
 import glob
 from distutils.core import setup
 from setupext import build_agg, build_gtkagg, build_tkagg, build_wxagg,\
      build_ft2font, build_image, build_windowing, build_path, \
      build_contour, build_nxutils, build_traits, build_gdk, \
-     build_subprocess, build_ttconv, print_line, print_status, print_message, \
+     build_ttconv, print_line, print_status, print_message, \
      print_raw, check_for_freetype, check_for_libpng, check_for_gtk, \
      check_for_tk, check_for_wx, check_for_numpy, check_for_qt, check_for_qt4, \
      check_for_cairo, check_provide_traits, check_provide_pytz, \
@@ -100,24 +87,7 @@
                               ]}
 
 if not check_for_numpy():
-    sys.exit()
-
-try: import subprocess
-except ImportError: havesubprocess = False
-else: havesubprocess = True
-
-if havesubprocess and sys.version < '2.4':
-    # Python didn't come with subprocess, so let's make sure it's
-    # not in some Python egg (e.g. an older version of matplotlib)
-    # that may get removed.
-    subprocess_dir = os.path.dirname(subprocess.__file__)
-    if subprocess_dir.endswith('.egg/subprocess'):
-        havesubprocess = False
-
-if not havesubprocess:
-    packages.append('subprocess')
-    if sys.platform == 'win32':
-        build_subprocess(ext_modules, packages)
+    sys.exit(1)
 
 if not check_for_freetype():
     sys.exit(1)
diff --git a/setupext.py b/setupext.py
@@ -532,38 +532,31 @@ def check_for_pdftops():
         return False
 
 def check_for_numpy():
-    gotit = False
     try:
         import numpy
     except ImportError:
         print_status("numpy", "no")
-        print_message("You must install numpy to build matplotlib.")
-        return False
-
-    major, minor1, minor2 = map(int, numpy.__version__.split('.')[:3])
-    if major<1 or (major==1 and minor1<1):
-        print_status("numpy version", "no")
         print_message("You must install numpy 1.1 or later to build matplotlib.")
-
         return False
-
+    nn = numpy.__version__.split('.')
+    if not (int(nn[0]) >= 1 and int(nn[1]) >= 1):
+        print_message(
+           'numpy 1.1 or later is required; you have %s' % numpy.__version__)
+        return False
     module = Extension('test', [])
     add_numpy_flags(module)
     add_base_flags(module)
 
     print_status("numpy", numpy.__version__)
     if not find_include_file(module.include_dirs, os.path.join("numpy", "arrayobject.h")):
         print_message("Could not find the headers for numpy.  You may need to install the development package.")
+        return False
     return True
 
 def add_numpy_flags(module):
     "Add the modules flags to build extensions which use numpy"
     import numpy
-    # TODO: Remove this try statement when it is no longer needed
-    try:
-        module.include_dirs.append(numpy.get_include())
-    except AttributeError:
-        module.include_dirs.append(numpy.get_numpy_include())
+    module.include_dirs.append(numpy.get_include())
 
 def add_agg_flags(module):
     'Add the module flags to build extensions which use agg'
@@ -1267,10 +1260,3 @@ def build_gdk(ext_modules, packages):
 
     BUILT_GDK = True
 
-def build_subprocess(ext_modules, packages):
-    module = Extension(
-        'subprocess._subprocess',
-        ['src/_subprocess.c', ],
-        )
-    add_base_flags(module)
-    ext_modules.append(module)
