Don't make an extra copy of the expected image outside of the result_images directory.

mdboom · mdboom · commit df4c96bd7ef3 · 2011-12-06T13:56:51.000-05:00
diff --git a/lib/matplotlib/testing/compare.py b/lib/matplotlib/testing/compare.py
@@ -232,19 +232,15 @@ def compare_images( expected, actual, tol, in_decorator=False ):
 
    diff_image = os.path.join(os.path.dirname(actual),
                              'failed-diff-'+os.path.basename(actual))
-   expected_copy = 'expected-'+os.path.basename(actual)
 
    if ( (rms / 10000.0) <= tol ):
       if os.path.exists(diff_image):
          os.unlink(diff_image)
-      if os.path.exists(expected_copy):
-         os.unlink(expected_copy)
       return None
 
    save_diff_image( expected, actual, diff_image )
 
    if in_decorator:
-      shutil.copyfile( expected, expected_copy )
       results = dict(
          rms = rms,
          expected = str(expected),
@@ -253,9 +249,6 @@ def compare_images( expected, actual, tol, in_decorator=False ):
          )
       return results
    else:
-      # expected_copy is only for in_decorator case
-      if os.path.exists(expected_copy):
-         os.unlink(expected_copy)
       # old-style call from mplTest directory
       msg = "  Error: Image files did not match.\n"       \
             "  RMS Value: " + str( rms / 10000.0 ) + "\n" \
