fix: retry on No window with id CDP error#892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues that cause Twitter and browser commands to fail with 'No window with id' after Chrome restart or window close.
Root Cause
Missing transient pattern —
src/browser/errors.tsTRANSIENT_ERROR_PATTERNSdid not include'No window with id', so the daemon-client retry logic skipped these errors and failed immediately.Early break in extension retry loop — In
extension/src/cdp.ts, whenchrome.tabs.get()throws (tab/window is gone), the retry loopbreaked immediately instead of continuing to retry. This prevented the retry mechanism from creating a fresh window.Changes
src/browser/errors.tsconst TRANSIENT_ERROR_PATTERNS = [ 'Extension disconnected', 'Extension not connected', 'attach failed', 'no longer exists', 'CDP connection', 'Daemon command failed', + 'No window with id', ] as const;extension/src/cdp.ts} catch { - lastError = `Tab ${tabId} no longer exists`; - break; + // Tab is gone — the window it belonged to was closed. + // Do NOT break; let the retry loop create a fresh window/tab. + lastError = `Tab ${tabId} no longer exists`; + // Don't break; fall through to retry }Impact
search,timeline, etc.) will now auto-recover after Chrome restart