Use branch index 1 of the jumps into the case instead of 0. #1939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently KotlinWhenStringFilter breaks branch coverage for String based when statements because the replacement branches into the case statements can never be covered. This is because the new branches point to the "first" branch of the unconditional jumps to the bodies of the case statement (after the String equality check). But the first branch of a jump is the "fallthrough" (the path if the jump is not taken), which is never taken for a simple goto. The target of a jump is the second branch. Fixes jacoco#1938
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently KotlinWhenStringFilter breaks branch coverage for String based when statements because the replacement branches into the case statements can never be covered.
This is because the new branches point to the "first" branch of the unconditional jumps to the bodies of the case statement (after the String equality check).
But the first branch of a jump is the "fallthrough" (the path if the jump is not taken), which is never taken for a simple goto. The target of a jump is the second branch.
Fixes #1938