Fix KotlinWhenStringFilter and StringSwitchFilter #1940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchof
reviewed
Aug 26, 2025
| } | ||
| } | ||
|
|
||
| private static void executedWithSameHashCodeAsFirstCase(Object s) { |
Member
There was a problem hiding this comment.
I was a bit confused by the method name until I saw the call site.
executedWithSameHashCodeAsFirstCase("\0a");
As is is only called here the parameter can be removed? To avoid that the compiler handles the constant directly we can introduce Stub.identity(String).
marchof
reviewed
Aug 26, 2025
| } // assertEmpty() | ||
| } // assertFullyCovered() | ||
|
|
||
| private fun executedWithSameHashCodeAsFirstCase(s: String) { |
Member
There was a problem hiding this comment.
Same comment as above: If we only have one use case we don't need a parameter.
Member
|
@Godin As the original issue is Kotlin specific: Can we add a validation test for Kotlin? |
Member
Author
marchof
approved these changes
Aug 27, 2025
7c54377 to
3288b9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1938
Closes #1939