Merge pull request #1640 from sogaiu/add-some-windows-commentary

bakpakin · web-flow · commit e601e8faabcc · 2025-09-15T15:29:38.000-05:00
Improve windows-related docs and notes
diff --git a/build_win.bat b/build_win.bat
@@ -49,6 +49,7 @@ for %%f in (src\boot\*.c) do (
 )
 %JANET_LINK% /out:build\janet_boot.exe build\boot\*.obj
 @if errorlevel 1 goto :BUILDFAIL
+@rem note that there is no default sysroot being baked in
 build\janet_boot . > build\c\janet.c
 @if errorlevel 1 goto :BUILDFAIL
 
diff --git a/janet.1 b/janet.1
@@ -214,7 +214,7 @@ Don't execute a script, only compile it to check for errors. Useful for linting
 .BR \-m\ syspath
 Set the dynamic binding :syspath to the string syspath so that Janet will load system modules
 from a directory different than the default. The default is set when Janet is built, and defaults to
-/usr/local/lib/janet on Linux/Posix, and C:/Janet/Library on Windows. This option supersedes JANET_PATH.
+/usr/local/lib/janet on Linux/Posix. On Windows, there is no default value. This option supersedes JANET_PATH.
 
 .TP
 .BR \-c\ source\ output
@@ -255,8 +255,7 @@ and then arguments to the script.
 .RS
 The location to look for Janet libraries. This is the only environment variable Janet needs to
 find native and source code modules. If no JANET_PATH is set, Janet will look in
-the default location set at compile time. This should be a list of as well as a colon
-separate list of such directories.
+the default location set at compile time. This should be a colon-separated list of directory names on Linux/Posix, and a semicolon-separated list on Windows. Note that a typical setup (i.e. not NixOS / Guix) will only use a single directory.
 .RE
 
 .B JANET_PROFILE
diff --git a/tools/msi/janet.wxs b/tools/msi/janet.wxs
@@ -37,6 +37,12 @@
 			 Version="$(var.Version)"
 			 Manufacturer="$(var.Manufacturer)"
 			 UpgradeCode="$(var.UpgradeCode)">
+       <!--
+         perUser means destination will be under user's %AppData% directory,
+         not Program Files or similar.
+
+         see: https://learn.microsoft.com/en-us/windows/win32/msi/installation-context
+       -->
         <Package Compressed="yes"
 				 InstallScope="perUser"
 				 Manufacturer="$(var.Manufacturer)"

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,7 @@ for %%f in (src\boot\*.c) do (`
`49`	`49`	`)`
`50`	`50`	`%JANET_LINK% /out:build\janet_boot.exe build\boot\*.obj`
`51`	`51`	`@if errorlevel 1 goto :BUILDFAIL`
	`52`	`+@rem note that there is no default sysroot being baked in`
`52`	`53`	`build\janet_boot . > build\c\janet.c`
`53`	`54`	`@if errorlevel 1 goto :BUILDFAIL`
`54`	`55`