Replicate PR545/546 in OTG telemetry basic test

jasdeep-hundal · jasdeep-hundal · commit 6ecbcbb62d8c · 2023-04-11T12:39:54.000-07:00
References: - openconfig#545 - openconfig#546
diff --git a/feature/gnmi/otg_tests/telemetry_basic_check_test/README.md b/feature/gnmi/otg_tests/telemetry_basic_check_test/README.md
@@ -22,6 +22,11 @@ following features:
         *   /interfaces/interfaces/interface/state/admin-status
         *   /interfaces/interfaces/interface/state/oper-status
 
+*   Interface physical channel
+
+    *   Check interface physical-channel exists.
+            *   /interfaces/interface/state/physical-channel
+
 *   Interface status change
 
     *   Check admin-status and oper-status are correct after interface flapping.
@@ -122,6 +127,7 @@ No configuration coverage.
 *   /interfaces/interface/state/hardware-port /interfaces/interface/state/id
 *   /interfaces/interface/state/oper-status
 *   /interfaces/interface/ethernet/state/port-speed
+*   /interfaces/interface/state/physical-channel
 *   /components/component/integrated-circuit/state/node-id
 *   /components/component/state/parent
 *   /interfaces/interface/state/counters/in-octets
diff --git a/feature/gnmi/otg_tests/telemetry_basic_check_test/telemetry_basic_check_test.go b/feature/gnmi/otg_tests/telemetry_basic_check_test/telemetry_basic_check_test.go
@@ -144,6 +144,17 @@ func TestInterfaceOperStatus(t *testing.T) {
 	}
 }
 
+func TestInterfacePhysicalChannel(t *testing.T) {
+	dut := ondatra.DUT(t, "dut")
+	dp := dut.Port(t, "port1")
+
+	phyChannel := gnmi.Get(t, dut, gnmi.OC().Interface(dp.Name()).PhysicalChannel().State())
+	t.Logf("Got %q PhysicalChannel from telmetry: %v", dp.Name(), phyChannel)
+	if len(phyChannel) == 0 {
+		t.Errorf("Get(DUT port1 PhysicalChannel): got empty %v, want non-empty list", phyChannel)
+	}
+}
+
 func TestInterfaceStatusChange(t *testing.T) {
 	dut := ondatra.DUT(t, "dut")
 	dp := dut.Port(t, "port2")
