Issue #20 Don't hide exceptions to the test, null is ugly

dmatej · dmatej · commit 7582ff25513a · 2018-07-30T23:04:05.000+02:00
- throws IllegalStateException if it cannot get session in 5 seconds
- (fail fast as possible)
diff --git a/servlet/http2/src/test/java/org/javaee8/servlet/http2/JettyConnector.java b/servlet/http2/src/test/java/org/javaee8/servlet/http2/JettyConnector.java
@@ -167,13 +167,11 @@ private Session createSession(String host, int port, boolean secure) {
             client.connect(new InetSocketAddress(host, port), new ServerSessionListener.Adapter(), sessionPromise);
         }
 
-        Session session = null;
         try {
-            session = sessionPromise.get(5, TimeUnit.SECONDS);
+            return sessionPromise.get(5, TimeUnit.SECONDS);
         } catch (InterruptedException | ExecutionException | TimeoutException e) {
-            e.printStackTrace();
+            throw new IllegalStateException("Cloud not get a session.", e);
         }
-        return session;
     }
 
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -167,13 +167,11 @@ private Session createSession(String host, int port, boolean secure) {`
`167`	`167`	`client.connect(new InetSocketAddress(host, port), new ServerSessionListener.Adapter(), sessionPromise);`
`168`	`168`	`}`
`169`	`169`
`170`		`- Session session = null;`
`171`	`170`	`try {`
`172`		`- session = sessionPromise.get(5, TimeUnit.SECONDS);`
	`171`	`+ return sessionPromise.get(5, TimeUnit.SECONDS);`
`173`	`172`	`} catch (InterruptedException \| ExecutionException \| TimeoutException e) {`
`174`		`- e.printStackTrace();`
	`173`	`+ throw new IllegalStateException("Cloud not get a session.", e);`
`175`	`174`	`}`
`176`		`- return session;`
`177`	`175`	`}`
`178`	`176`
`179`		`-}`
	`177`	`+}`