fixed duplicate cell id bug

AceTheCreator · AceTheCreator · commit 2326e62fd8cc · 2021-05-25T02:47:15.000+01:00
diff --git a/src/Cell.js b/src/Cell.js
@@ -95,9 +95,7 @@ export default function Cell({
     }
   };
 
-  const setId = () => {
-    // eslint-disable-next-line radix
-    const id = currentCell || parseInt(cell.id.split("_")[1]);
+  const setId = (id) => {
     setCurrentCell(id);
   };
 
@@ -111,7 +109,9 @@ export default function Cell({
       refCode.current.getCodeMirror().setValue(cell.input);
       refOutput.current.innerHTML = cell.output;
     }
-    setId();
+    // eslint-disable-next-line radix
+    const id = parseInt(cell.id.split("_")[1]);
+    setId(id);
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [cell]);
 
@@ -130,7 +130,6 @@ export default function Cell({
   const newCell = (id, type) => {
     // eslint-disable-next-line no-shadow
     const newCell = {
-      id: `cell_${currentCell + 1}`,
       input: "",
     };
 
diff --git a/src/pages/demo/demo.js b/src/pages/demo/demo.js
@@ -5,7 +5,7 @@ import { downLoad_notebook, load_notebook } from "../../utils";
 import Header from "../../components/header/header";
 
 const defaultState = {
-  cells: [{ id: "cell_1", input: "", output: "", type: "code" }],
+  cells: [{ input: "", output: "", type: "code", id: "cell_1" }],
 };
 
 export default function Demo() {
diff --git a/src/reducer.js b/src/reducer.js
@@ -15,9 +15,21 @@ export const reducer = (state, action) => {
   }
 
   if (action.type === "ADD_CELL") {
+    // Id generation is been done here because of the issue with dupluicate
+    // ids generated when using an existing note
     const newCell = [...state.cells];
-    newCell.splice(action.currentId, 0, action.payload);
-    console.log(state);
+    const getMax = Math.max(
+      // eslint-disable-next-line func-names
+      ...newCell.map(function (o) {
+        // eslint-disable-next-line radix
+        return parseInt(o.id.split("_")[1]);
+      })
+    );
+    const { payload } = action;
+    payload.id = `cell_${getMax + 1}`;
+    console.log(payload);
+    newCell.splice(action.currentId, 0, payload);
+    console.log(newCell);
     return {
       ...state,
       cells: newCell,
