Added the device revision support for linux and fixed NUMANodeID read process#273
Draft
leonardowitt wants to merge 1 commit into
Draft
Added the device revision support for linux and fixed NUMANodeID read process#273leonardowitt wants to merge 1 commit into
leonardowitt wants to merge 1 commit into
Conversation
jaypipes
requested changes
Sep 10, 2021
Owner
jaypipes
left a comment
There was a problem hiding this comment.
This looks great, Leonardo, thank you for the contribution!
There's no need to include Windows support in this particular PR, however one thing I would ask is that you actually submit two PRs, one for the fix to the disk's NUMA Node ID collection and the other PR containing the new disk Revision field. That way, if we need to revert one of the fixes/features, we don't need to revert everything.
Best,
-jay
| if nodeContents, err := ioutil.ReadFile(filepath.Join(paths.SysBlock, partial, "numa_node")); err != nil { | ||
| if nodeInt, err := strconv.Atoi(string(nodeContents)); err != nil { | ||
| if nodeContents, err := ioutil.ReadFile(filepath.Join(paths.SysBlock, partial, "numa_node")); err == nil { | ||
| if nodeInt, err := strconv.Atoi(string(nodeContents)); err == nil { |
Collaborator
There was a problem hiding this comment.
Indeed! but this would deserve a separate PR
ffromani
reviewed
Jan 31, 2022
| if nodeContents, err := ioutil.ReadFile(filepath.Join(paths.SysBlock, partial, "numa_node")); err != nil { | ||
| if nodeInt, err := strconv.Atoi(string(nodeContents)); err != nil { | ||
| if nodeContents, err := ioutil.ReadFile(filepath.Join(paths.SysBlock, partial, "numa_node")); err == nil { | ||
| if nodeInt, err := strconv.Atoi(string(nodeContents)); err == nil { |
Collaborator
There was a problem hiding this comment.
Indeed! but this would deserve a separate PR
| return strings.TrimSpace(string(contents)) | ||
| } | ||
|
|
||
| func diskRevision(paths *linuxpath.Paths, disk string) string { |
Collaborator
There was a problem hiding this comment.
it's ok to add support for linux first and add a TODO for windows/mac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm opening it as a draft since I didn't implement the device revision support to Windows.