bug symfony#44976 [FrameworkBundle] Avoid calling rtrim(null, '/') in AssetsInstallCommand (pavol-tk, GromNaN)

GromNaN · GromNaN · commit c7a5902a2065 · 2022-01-12T12:20:40.000+01:00
This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] Avoid calling rtrim(null, '/') in AssetsInstallCommand | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT Avoid following deprecation notice: ``` php.INFO: Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated ``` Commits ------- 3d92f98 [FrameworkBundle] Avoid calling rtrim(null, '/') in AssetsInstallCommand
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php
@@ -99,8 +99,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
     {
         /** @var KernelInterface $kernel */
         $kernel = $this->getApplication()->getKernel();
-        $targetArg = rtrim($input->getArgument('target'), '/');
-
+        $targetArg = rtrim($input->getArgument('target') ?? '', '/');
         if (!$targetArg) {
             $targetArg = $this->getPublicDirectory($kernel->getContainer());
         }

Original file line number	Diff line number	Diff line change
`@@ -99,8 +99,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int`
`99`	`99`	`{`
`100`	`100`	`/** @var KernelInterface $kernel */`
`101`	`101`	`$kernel = $this->getApplication()->getKernel();`
`102`		`- $targetArg = rtrim($input->getArgument('target'), '/');`
`103`		`-`
	`102`	`+ $targetArg = rtrim($input->getArgument('target') ?? '', '/');`
`104`	`103`	`if (!$targetArg) {`
`105`	`104`	`$targetArg = $this->getPublicDirectory($kernel->getContainer());`
`106`	`105`	`}`