Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@radoslavkarlik
Copy link
Contributor

Implements the issue #203

@DirtyF DirtyF requested a review from a team May 28, 2019 10:06
@parkr
Copy link
Member

parkr commented Jun 14, 2019

Thank you so much! The code looks great. Let's get a quick test in here.

In spec/jekyll_redirect_from/generator_spec.rb, let's add:

context "redirectable_document?" do
  let(:generator) { JekyllRedirectFrom::Generator.new }
  it "accepts subclasses of Jekyll::Document" do
    SubclassOfJekyllDocument = Class.new(Jekyll::Document)
    expect(generator.send(:redirectable_document?, SubclassOfJekyllDocument.new)).to be_truthy
  end

  it "accepts subclasses of Jekyll::Document" do
    SubclassOfJekyllPage = Class.new(Jekyll::Page)
    expect(generator.send(:redirectable_document?, SubclassOfJekyllPage.new)).to be_truthy
  end
end

I haven't run the above code but hopefully it gets you started. 🚀

@radoslavkarlik
Copy link
Contributor Author

Sorry guys, busy life happened. I have added the tests with a little modification.

@ashmaroli ashmaroli requested a review from a team December 12, 2019 12:09
@DirtyF
Copy link
Member

DirtyF commented Jan 26, 2020

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 475bdf9 into jekyll:master Jan 26, 2020
jekyllbot added a commit that referenced this pull request Jan 26, 2020
@radoslavkarlik radoslavkarlik deleted the feature/allow_redirects_for_subclasses branch January 27, 2020 08:31
@jekyll jekyll locked and limited conversation to collaborators Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants