Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refactor specs for RedirectPage #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 14, 2020
Merged

Refactor specs for RedirectPage #222

merged 7 commits into from
Sep 14, 2020

Conversation

@satyanash
Copy link
Contributor

@satyanash satyanash commented Aug 15, 2020 •
edited
Loading

I was planning to take a crack at #214 and realized that the specs for RedirectPage could do with some refactoring before actually implementing the fix for it. Would like to get the refactor merged before moving on to the actual fix.

At a high level the refactor does the following:

  • Extract common code into an rspec shared_examples block.
  • Stop using RedirectPage.from_paths in the spec. and makes it private.
  • Only use RedirectPage.redirect_from and RedirectPage.redirect_to in the spec.
  • Split the specs into two high level contexts for each of the two public class methods.

@satyanash satyanash force-pushed the refactor-specs-redirect-page branch from f607ec7 to 69ad919 Compare August 15, 2020 10:14
@satyanash
Copy link
Contributor Author

satyanash commented Aug 15, 2020

Current failures are on JEKYLL_VERSION="~> 3.8" due to kramdown-parser-gfm being unavailable in jekyll 3.9
Have submitted another fix for this in #223 to lock JEKYLL_VERISON='~> 3.8.0'.

@satyanash
Copy link
Contributor Author

satyanash commented Aug 15, 2020

#223 is closed in favour of #224

@satyanash
Copy link
Contributor Author

satyanash commented Aug 16, 2020

All CI checks are now passing for this refactor.

ashmaroli
ashmaroli reviewed Aug 16, 2020
View reviewed changes
@ashmaroli ashmaroli requested a review from a team August 16, 2020 15:52
@satyanash satyanash force-pushed the refactor-specs-redirect-page branch from 5a9e702 to ecedb76 Compare August 16, 2020 15:57
@satyanash
Copy link
Contributor Author

satyanash commented Aug 18, 2020

@ashmaroli May I know what is blocking the merge for this PR?
I'm unable to find a user called @jekyll/plugin-core

@ashmaroli
Copy link
Member

ashmaroli commented Aug 18, 2020

@jekyll/plugin-core is a ping to a team of members within the Jekyll organization on GitHub that maintain plugins under the Org. You may not see details if you don't have sufficient privileges.

Either ways, this is going to wait for couple of days for a response from the team.
You're welcome to start work on a new branch created off this branch and then rebase once this gets merged into master.

@ashmaroli
Copy link
Member

ashmaroli commented Sep 14, 2020

Thanks @satyanash
@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 8eff45b into jekyll:master Sep 14, 2020
jekyllbot added a commit that referenced this pull request Sep 14, 2020
@jekyllbot
Update history to reflect merge of #222 [ci skip]
18af463
@satyanash satyanash deleted the refactor-specs-redirect-page branch September 14, 2020 12:16
@jekyll jekyll locked and limited conversation to collaborators Nov 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ashmaroli ashmaroli ashmaroli left review comments

Assignees

No one assigned

Labels

fix frozen-due-to-age internal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@satyanash @ashmaroli @jekyllbot