tests/offline: use assertIn()/assertNotIn() instead of assertTrue()

kernc · kernc · commit 833cddc68f11 · 2017-04-20T00:13:16.000+02:00
The benefit is in the more informative context when the tests fail.
diff --git a/plotly/tests/test_core/test_offline/test_offline.py b/plotly/tests/test_core/test_offline/test_offline.py
@@ -56,22 +56,23 @@ def test_default_plot_generates_expected_html(self):
 
         # I don't really want to test the entire script output, so
         # instead just make sure a few of the parts are in here?
-        self.assertTrue('Plotly.newPlot' in html) # plot command is in there
-        self.assertTrue(data_json in html)        # data is in there
-        self.assertTrue(layout_json in html)      # so is layout
-        self.assertTrue(PLOTLYJS in html)         # and the source code
+        self.assertIn('Plotly.newPlot', html)  # plot command is in there
+        self.assertIn(data_json, html)         # data is in there
+        self.assertIn(layout_json, html)       # so is layout
+        self.assertIn(PLOTLYJS, html)          # and the source code
         # and it's an <html> doc
         self.assertTrue(html.startswith('<html>') and html.endswith('</html>'))
 
     def test_including_plotlyjs(self):
         html = self._read_html(plotly.offline.plot(fig, include_plotlyjs=False,
                                                    auto_open=False))
-        self.assertTrue(PLOTLYJS not in html)
+        self.assertNotIn(PLOTLYJS, html)
 
     def test_div_output(self):
         html = plotly.offline.plot(fig, output_type='div', auto_open=False)
 
-        self.assertTrue('<html>' not in html and '</html>' not in html)
+        self.assertNotIn('<html>', html)
+        self.assertNotIn('</html>', html)
         self.assertTrue(html.startswith('<div>') and html.endswith('</div>'))
 
     def test_autoresizing(self):
@@ -82,7 +83,7 @@ def test_autoresizing(self):
         # If width or height wasn't specified, then we add a window resizer
         html = self._read_html(plotly.offline.plot(fig, auto_open=False))
         for resize_code_string in resize_code_strings:
-            self.assertTrue(resize_code_string in html)
+            self.assertIn(resize_code_string, html)
 
         # If width or height was specified, then we don't resize
         html = self._read_html(plotly.offline.plot({
@@ -92,7 +93,7 @@ def test_autoresizing(self):
             }
         }, auto_open=False))
         for resize_code_string in resize_code_strings:
-            self.assertTrue(resize_code_string not in html)
+            self.assertNotIn(resize_code_string, html)
 
     def test_config(self):
         config = dict(linkText='Plotly rocks!',
@@ -115,7 +116,7 @@ def test_plot_rendered_if_non_plotly_domain(self):
         html = plotly.offline.plot(fig, output_type='div')
 
         # test that 'Export to stage.plot.ly' is in the html
-        self.assertTrue('Export to stage.plot.ly' in html)
+        self.assertIn('Export to stage.plot.ly', html)
 
     def tearDown(self):
         plotly.tools.set_config_file(plotly_domain='https://plot.ly',
