From 8b87509e2be18443d1772fdc2d071e743c23ea0d Mon Sep 17 00:00:00 2001 From: Nikita Panteleev Date: Sun, 20 Aug 2023 19:08:49 +0200 Subject: [PATCH 1/3] Marks Reporter's hooks as optional onRunStart and getLastError should be optional --- packages/jest-reporters/src/types.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/jest-reporters/src/types.ts b/packages/jest-reporters/src/types.ts index 3f285ba9f285..3a5338354728 100644 --- a/packages/jest-reporters/src/types.ts +++ b/packages/jest-reporters/src/types.ts @@ -42,7 +42,7 @@ export interface Reporter { test: Test, testCaseResult: TestCaseResult, ) => Promise | void; - readonly onRunStart: ( + readonly onRunStart?: ( results: AggregatedResult, options: ReporterOnStartOptions, ) => Promise | void; @@ -52,7 +52,7 @@ export interface Reporter { testContexts: Set, results: AggregatedResult, ) => Promise | void; - readonly getLastError: () => Error | void; + readonly getLastError?: () => Error | void; } export type ReporterContext = { From 9f1d1ed14edd83855e145a970bc85f25867c897a Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Mon, 21 Aug 2023 14:05:11 +0200 Subject: [PATCH 2/3] onRunComplete as well --- packages/jest-reporters/src/types.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/jest-reporters/src/types.ts b/packages/jest-reporters/src/types.ts index 3a5338354728..a33e6ddd4f65 100644 --- a/packages/jest-reporters/src/types.ts +++ b/packages/jest-reporters/src/types.ts @@ -48,7 +48,7 @@ export interface Reporter { ) => Promise | void; readonly onTestStart?: (test: Test) => Promise | void; readonly onTestFileStart?: (test: Test) => Promise | void; - readonly onRunComplete: ( + readonly onRunComplete?: ( testContexts: Set, results: AggregatedResult, ) => Promise | void; From d2ddc68579cf991510b90ca62468ce017141e93f Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Mon, 21 Aug 2023 14:05:51 +0200 Subject: [PATCH 3/3] changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 010e2c3aa459..4d1eee2fa147 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,7 @@ - `[jest-mock]` Revert [#13692](https://github.com/jestjs/jest/pull/13692) as it was a breaking change ([#14429](https://github.com/jestjs/jest/pull/14429)) - `[jest-mock]` Revert [#13866](https://github.com/jestjs/jest/pull/13866) as it was a breaking change ([#14429](https://github.com/jestjs/jest/pull/14429)) - `[jest-mock]` Revert [#13867](https://github.com/jestjs/jest/pull/13867) as it was a breaking change ([#14429](https://github.com/jestjs/jest/pull/14429)) +- `[@jest/reporters]` Marks Reporter's hooks as optional ([#14433](https://github.com/jestjs/jest/pull/14433)) ### Chore & Maintenance