Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: eggjs/egg
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: next
Choose a base ref
...
head repository: jingmingji/egg
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 12 commits
  • 3 files changed
  • 2 contributors

Commits on Apr 8, 2018

  1. 调整了socket.join(room)方法的执行顺序 

    1、socket.join(room)放到了nsp.adapter.clients()里面有问题，导致clients返回到前端无法正常携带当前的socket信息，应该把socket.join(room)放到nsp.adapter.clients()外面先执行，亲测如此可以正常返回clients数据。
2、另外clients[id] = query，这个操作和插件本身的操作有冲突，因为socket.join(room)调用成功后，会自动将socketid放入到clients数组里面。如果想添加多余的信息可以通过其他字段来返回，没必要对这个插件会调用的属性进行操作。
    @jingmingji
    jingmingji authored Apr 8, 2018
    Configuration menu
    Copy the full SHA
    5e9b7c7 View commit details
    Browse the repository at this point in the history

  2. Update socketio.md

    @jingmingji
    jingmingji authored Apr 8, 2018
    Configuration menu
    Copy the full SHA
    c8fbd17 View commit details
    Browse the repository at this point in the history

  3. Add files via upload

    @jingmingji
    jingmingji authored Apr 8, 2018
    Configuration menu
    Copy the full SHA
    342fe88 View commit details
    Browse the repository at this point in the history

  4. 上传socketio文档图片

    @jingmingji
    jingmingji committed Apr 8, 2018
    Configuration menu
    Copy the full SHA
    6a9fa89 View commit details
    Browse the repository at this point in the history

  5. 修改了效果截图

    @jingmingji
    jingmingji authored Apr 8, 2018
    Configuration menu
    Copy the full SHA
    3788d54 View commit details
    Browse the repository at this point in the history

  6. Update socketio.md

    @jingmingji
    jingmingji authored Apr 8, 2018
    Configuration menu
    Copy the full SHA
    7599937 View commit details
    Browse the repository at this point in the history

  7. Update socketio.md

    @jingmingji
    jingmingji authored Apr 8, 2018
    Configuration menu
    Copy the full SHA
    4406103 View commit details
    Browse the repository at this point in the history

  8. Update socketio.md

    @jingmingji
    jingmingji authored Apr 8, 2018
    Configuration menu
    Copy the full SHA
    139b2c4 View commit details
    Browse the repository at this point in the history

  9. Update socketio.md

    @jingmingji
    jingmingji authored Apr 8, 2018
    Configuration menu
    Copy the full SHA
    f06dd13 View commit details
    Browse the repository at this point in the history

  10. 删除了误传的图片文件

    @jingmingji
    jingmingji committed Apr 8, 2018
    Configuration menu
    Copy the full SHA
    e6a1e6e View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2018

  1. Merge branch 'master' into master

    @jingmingji
    jingmingji authored Apr 9, 2018
    Configuration menu
    Copy the full SHA
    0f4cc41 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into master

    @jingmingji
    jingmingji authored Apr 9, 2018
    Configuration menu
    Copy the full SHA
    568af38 View commit details
    Browse the repository at this point in the history
Loading