Add typings for modifyEager

willsoto · koskimas · commit a1d0a82acbdf · 2019-04-09T07:57:45.000+03:00
Closes Vincit#1277 Signed-off-by: Will Soto <willsoto@users.noreply.github.com>
diff --git a/tests/ts/examples.ts b/tests/ts/examples.ts
@@ -521,7 +521,9 @@ const children: Promise<Person[]> = Person.query()
 const childrenAndPets: Promise<Person[]> = Person.query()
   .eager('children')
   .where('age', '>=', 42)
-  .modifyEager('[pets, children.pets]', qb => qb.orderBy('name'));
+  .modifyEager('[pets, children.pets]', qb => qb.orderBy('name'))
+  .modifyEager('[pets, children.pets]', 'orderByName')
+  .modifyEager('[pets, children.pets]', ['orderByName', 'orderBySomethingElse']);
 
 const rowsPage: Promise<{
   total: number;
diff --git a/typings/objection/index.d.ts b/typings/objection/index.d.ts
@@ -372,6 +372,10 @@ declare namespace Objection {
       relationExpression: RelationExpression,
       modifier: (builder: QueryBuilder<QM2, QM2[]>) => void
     ): QueryBuilder<QM1, RM1, RV1>;
+    <QM2 extends Model>(
+      relationExpression: RelationExpression,
+      modifier: string | string[]
+    ): QueryBuilder<QM1, RM1, RV1>;
   }
 
   interface BluebirdMapper<T, Result> {
