FIX default process backend when multiprocessing is disabled - #1721
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1721 +/- ##
==========================================
- Coverage 95.56% 95.56% -0.01%
==========================================
Files 46 46
Lines 7874 7884 +10
==========================================
+ Hits 7525 7534 +9
- Misses 349 350 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
LGTM thanks!
Since no-multiprocessing build is passing, I am pretty sure that it should fix it for Pyodide too.
To try to be explicit: before this PR, there were no tests that was doing Parallel(prefer="processes") when multiprocessing was disabled (e.g. Pyodide or JOBLIB_MULTIPROCESSING=0). In other words the existing tests using Parallel(prefer="processes") all used the with_multiprocessing decorator.
|
@tomMoral shall we release 1.5.1 for this regression fix? |
|
To be honest there is no rush, since my work-around PR in scikit-learn was merged scikit-learn/scikit-learn#31402. Note that this doesn't affect most Pyodide users, since Pyodide still uses joblib 1.4.2 unless the user explicitly does something like |
Fix #1720