Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@skarsaune
Copy link
Contributor

Here is a documentation draft. Took some time to figure out the mechanics, and not sure about the outcome.
Please have a look

@skarsaune
Copy link
Contributor Author

skarsaune commented Oct 14, 2021

@dboreham ref: #471 you may try to build the documentation from this branch

@rhuss
Copy link
Member

rhuss commented Oct 15, 2021

@skarsaune thanks ! Let me try to review the PR over the weekend and include the PR.

@rhuss
Copy link
Member

rhuss commented Dec 1, 2021

Thanks a lot, the PR looks good in general.

However, I think we need some tuning wrt/ formatting and wording. Would you mind if I push some polishing updates to your branch ?

@rhuss
Copy link
Member

rhuss commented Dec 2, 2021

I adjusted the wording a bit and cleaned up the formatting. @skarsaune please check, if this looks ok for you then we could merge.

One thing for the future: It would be cool to have a section with which options are possible when creating the connection, maybe as a table or so. The examples are a good start but I think people want to know what options are all possible. For common JSR-160 options we can refer to the official JMX documentation.

@skarsaune
Copy link
Contributor Author

Changes look great thanks. Will think about a table of options when things calm down a bit. Sorry for the late reply.

@rhuss
Copy link
Member

rhuss commented Dec 6, 2021

cool, so lets the changes merged and I will recreate the website later today.

@rhuss rhuss merged commit 680d12a into jolokia:master Dec 6, 2021
@rhuss
Copy link
Member

rhuss commented Dec 6, 2021

Website has been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants