Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit ed2b1a4

Browse files
desrosjdesrosj
committed
Build/Test Tools: Avoid logging the same debug info twice in the PHPUnit workflow.
Also includes some inline documentation fixes for workflow files. See #50401. git-svn-id: https://develop.svn.wordpress.org/trunk@49371 602fd350-edb4-49c9-b593-d223f7449a82
1 parent 6b2f57d commit ed2b1a4

4 files changed

Lines changed: 9 additions & 11 deletions

File tree

‎.github/workflows/end-to-end-tests.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,14 @@ jobs:
2020
# - Set environment variables.
2121
# - Checks out the repository.
2222
# - Logs debug information about the runner container.
23-
# - Installs NodeJS 12 (todo: install the version of NPM specified in the `.nvmrc` file to support older branches)
23+
# - Installs NodeJS 12 (todo: install the version of NPM specified in the `.nvmrc` file to support older branches).
2424
# - Sets up caching for NPM.
2525
# _ Installs NPM dependencies using install-changed to hash the `package.json` file.
2626
# - Builds WordPress to run from the `build` directory.
2727
# - Starts the WordPress Docker container.
2828
# - Logs general debug information.
2929
# - Logs the running Docker containers.
30-
# - Logs Docker debug information (about both the Docker installation within the runner and the WordPress container)
30+
# - Logs Docker debug information (about both the Docker installation within the runner and the WordPress container).
3131
# - Install WordPress within the Docker container.
3232
# - Run the E2E tests.
3333
# - todo: Configure Slack notifications for failing tests.

‎.github/workflows/javascript-tests.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
# - Cancels all previous workflow runs for pull requests that have not completed.
1515
# - Checks out the repository.
1616
# - Logs debug information about the runner container.
17-
# - Installs NodeJS 12 (todo: install the version of NPM specified in the `.nvmrc` file to support older branches)
17+
# - Installs NodeJS 12 (todo: install the version of NPM specified in the `.nvmrc` file to support older branches).
1818
# - Sets up caching for NPM.
1919
# - Logs updated debug information.
2020
# _ Installs NPM dependencies using install-changed to hash the `package.json` file.

‎.github/workflows/phpunit-tests.yml‎

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,11 @@ jobs:
2626
# - Checks out the repository.
2727
# - Checks out the WordPress Importer plugin (needed for the Core PHPUnit tests).
2828
# - Logs debug information about the runner container.
29-
# - Installs NodeJS 12 (todo: install the version of NPM specified in the `.nvmrc` file to support older branches)
29+
# - Installs NodeJS 12 (todo: install the version of NPM specified in the `.nvmrc` file to support older branches).
3030
# - Sets up caching for NPM.
3131
# _ Installs NPM dependencies using install-changed to hash the `package.json` file.
3232
# - Builds WordPress to run from the `build` directory.
33-
# - Creates a ZIP file of compiled WordPress
33+
# - Creates a ZIP file of compiled WordPress.
3434
# - Uploads ZIP file as an artifact.
3535
setup-wordpress:
3636
name: Setup WordPress
@@ -108,14 +108,14 @@ jobs:
108108
# - Sets up caching for NPM.
109109
# _ Installs NPM dependencies using install-changed to hash the `package.json` file.
110110
# - Configures caching for Composer.
111-
# _ Installs Composer dependencies (if desired)
112-
# - Logs Docker debug information (about both the Docker installation within the runner)
111+
# _ Installs Composer dependencies (if desired).
112+
# - Logs Docker debug information (about both the Docker installation within the runner).
113113
# - Starts the WordPress Docker container.
114114
# - Starts the memcached server after the Docker network has been created (if desired).
115115
# - Logs WordPress Docker container debug information.
116116
# - Logs debug general information.
117117
# - Logs the running Docker containers.
118-
# - Logs Docker debug information (about both the Docker installation within the runner and the WordPress container)
118+
# - Logs debug information about what's installed within the WordPress Docker containers.
119119
# - Install WordPress within the Docker container.
120120
# - Run the PHPUnit tests.
121121
# - Reports test results to the Distributed Hosting Tests.
@@ -236,8 +236,6 @@ jobs:
236236

237237
- name: WordPress Docker container debug information
238238
run: |
239-
docker -v
240-
docker-compose -v
241239
docker-compose run --rm mysql mysql --version
242240
docker-compose run --rm php php --version
243241
docker-compose run --rm php php -m

‎.github/workflows/verify-npm-on-windows.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
# - Cancels all previous workflow runs for pull requests that have not completed.
1818
# - Checks out the repository.
1919
# - Logs debug information about the runner container.
20-
# - Installs NodeJS 12 (todo: install the version of NPM specified in the `.nvmrc` file to support older branches)
20+
# - Installs NodeJS 12 (todo: install the version of NPM specified in the `.nvmrc` file to support older branches).
2121
# - Sets up caching for NPM.
2222
# _ Installs NPM dependencies using install-changed to hash the `package.json` file.
2323
# - Builds WordPress to run from the `build` directory.

0 commit comments

Comments
 (0)