BREAKING: copy*(): Error when unknown file type is encountered (#880)

RyanZim · web-flow · commit 2fca5b213c86 · 2021-04-02T07:52:47.000-04:00
Replaces & closes #812
diff --git a/lib/copy-sync/copy-sync.js b/lib/copy-sync/copy-sync.js
@@ -47,6 +47,9 @@ function getStats (destStat, src, dest, opts) {
            srcStat.isCharacterDevice() ||
            srcStat.isBlockDevice()) return onFile(srcStat, destStat, src, dest, opts)
   else if (srcStat.isSymbolicLink()) return onLink(destStat, src, dest, opts)
+  else if (srcStat.isSocket()) throw new Error(`Cannot copy a socket file: ${src}`)
+  else if (srcStat.isFIFO()) throw new Error(`Cannot copy a FIFO pipe: ${src}`)
+  throw new Error(`Unknown file: ${src}`)
 }
 
 function onFile (srcStat, destStat, src, dest, opts) {
diff --git a/lib/copy/copy.js b/lib/copy/copy.js
@@ -72,6 +72,9 @@ function getStats (destStat, src, dest, opts, cb) {
              srcStat.isCharacterDevice() ||
              srcStat.isBlockDevice()) return onFile(srcStat, destStat, src, dest, opts, cb)
     else if (srcStat.isSymbolicLink()) return onLink(destStat, src, dest, opts, cb)
+    else if (srcStat.isSocket()) return cb(new Error(`Cannot copy a socket file: ${src}`))
+    else if (srcStat.isFIFO()) return cb(new Error(`Cannot copy a FIFO pipe: ${src}`))
+    return cb(new Error(`Unknown file: ${src}`))
   })
 }
 

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,9 @@ function getStats (destStat, src, dest, opts) {`
`47`	`47`	`srcStat.isCharacterDevice() \|\|`
`48`	`48`	`srcStat.isBlockDevice()) return onFile(srcStat, destStat, src, dest, opts)`
`49`	`49`	`else if (srcStat.isSymbolicLink()) return onLink(destStat, src, dest, opts)`
	`50`	+ else if (srcStat.isSocket()) throw new Error(`Cannot copy a socket file: ${src}`)
	`51`	+ else if (srcStat.isFIFO()) throw new Error(`Cannot copy a FIFO pipe: ${src}`)
	`52`	+ throw new Error(`Unknown file: ${src}`)
`50`	`53`	`}`
`51`	`54`
`52`	`55`	`function onFile (srcStat, destStat, src, dest, opts) {`
Original file line number	Diff line number	Diff line change
`@@ -72,6 +72,9 @@ function getStats (destStat, src, dest, opts, cb) {`
`72`	`72`	`srcStat.isCharacterDevice() \|\|`
`73`	`73`	`srcStat.isBlockDevice()) return onFile(srcStat, destStat, src, dest, opts, cb)`
`74`	`74`	`else if (srcStat.isSymbolicLink()) return onLink(destStat, src, dest, opts, cb)`
	`75`	+ else if (srcStat.isSocket()) return cb(new Error(`Cannot copy a socket file: ${src}`))
	`76`	+ else if (srcStat.isFIFO()) return cb(new Error(`Cannot copy a FIFO pipe: ${src}`))
	`77`	+ return cb(new Error(`Unknown file: ${src}`))
`75`	`78`	`})`
`76`	`79`	`}`
`77`	`80`