Don't throw exceptions for (p)connect calls.

Mathieu Kooiman · Mathieu Kooiman · commit 7e4cdb47f41e · 2013-07-29T14:00:36.000+02:00
When Redis::(p)connect() is called on a newly created Redis instance that will always cause an exception to be thrown. The connect code will actually try and cancel the
exception but this is problematic when you are using tools like APM (pecl.php.net/apm) which hook into the exception handler: it will already have handled it. This change simply stops the connect from throwing exceptions for that situation.
diff --git a/redis.c b/redis.c
@@ -629,7 +629,7 @@ PHPAPI int redis_connect(INTERNAL_FUNCTION_PARAMETERS, int persistent) {
 	}
 
 	/* if there is a redis sock already we have to remove it from the list */
-	if (redis_sock_get(object, &redis_sock TSRMLS_CC, 0) > 0) {
+	if (redis_sock_get(object, &redis_sock TSRMLS_CC, 1) > 0) {
 		if (zend_hash_find(Z_OBJPROP_P(object), "socket",
 					sizeof("socket"), (void **) &socket) == FAILURE) {
 			/* maybe there is a socket but the id isn't known.. what to do? */

Original file line number	Diff line number	Diff line change
`@@ -629,7 +629,7 @@ PHPAPI int redis_connect(INTERNAL_FUNCTION_PARAMETERS, int persistent) {`
`629`	`629`	`}`
`630`	`630`
`631`	`631`	`/* if there is a redis sock already we have to remove it from the list */`
`632`		`- if (redis_sock_get(object, &redis_sock TSRMLS_CC, 0) > 0) {`
	`632`	`+ if (redis_sock_get(object, &redis_sock TSRMLS_CC, 1) > 0) {`
`633`	`633`	`if (zend_hash_find(Z_OBJPROP_P(object), "socket",`
`634`	`634`	`sizeof("socket"), (void **) &socket) == FAILURE) {`
`635`	`635`	`/* maybe there is a socket but the id isn't known.. what to do? */`