Make sure errstr is set before freeing it

michael-grunder · michael-grunder · commit 9f865c15b459 · 2015-05-07T12:44:20.000-07:00
diff --git a/library.c b/library.c
@@ -1647,7 +1647,7 @@ PHP_REDIS_API int redis_sock_connect(RedisSock *redis_sock TSRMLS_DC)
     efree(host);
 
     if (!redis_sock->stream) {
-        efree(errstr);
+        if (errstr) efree(errstr);
         return -1;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1647,7 +1647,7 @@ PHP_REDIS_API int redis_sock_connect(RedisSock *redis_sock TSRMLS_DC)`
`1647`	`1647`	`efree(host);`
`1648`	`1648`
`1649`	`1649`	`if (!redis_sock->stream) {`
`1650`		`- efree(errstr);`
	`1650`	`+ if (errstr) efree(errstr);`
`1651`	`1651`	`return -1;`
`1652`	`1652`	`}`
`1653`	`1653`