Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Simplify JSON_INT_MAX #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Simplify JSON_INT_MAX #102

wants to merge 1 commit into from

Conversation

per-ok
Copy link
Contributor

@per-ok per-ok commented Aug 3, 2021 •
edited
Loading

Simplifies the JSON_INT_MAX expression.

Thanks to @LB-- for suggesting to use CHAR_INT instead of 8 (char type is defined as at least 8 bits).

@LB--
Copy link
Member

LB-- commented Aug 7, 2021

Seems alright to me, though I wonder if the #include <stdint.h> stuff at the top of the file can be safely removed now? I don't see any other obvious places in the source where that header's content was needed.

@LB-- LB-- mentioned this pull request Aug 7, 2021
Closed
@DimitriPapadopoulos
Copy link
Contributor

DimitriPapadopoulos commented Aug 7, 2021 •
edited
Loading

I agree <stdint.h> should be removed from json.c, but it should be included by json.h instead of <inttypes.h>:

#ifndef json_int_t
   #ifndef _MSC_VER
      #include <inttypes.h>
      #define json_int_t int64_t

Indeed, the int64_t type is defined in <stdint.h>. Actually, <inttypes.h> includes <stdint.h> and simply defines additional printf-related macros for the types defined in <stdint.h>, which are not needed here as far as I can see.

Fixed by pull request #109.

@DimitriPapadopoulos
Copy link
Contributor

DimitriPapadopoulos commented Aug 10, 2021 •
edited
Loading

Header <limits.h> is ANSI C, so this patch looks good.

Indeed, <stdint.h> can be removed. Note that it will be added back by #109, but for #ifndef _MSC_VER, not for #ifdef _MSC_VER.

@LB-- LB-- added this to the v1.1.1 milestone Aug 14, 2021
LB-- added a commit to LB--/json-parser that referenced this pull request Aug 14, 2021
@LB--
Merge json-parser#102: improve JSON_INT_MAX
cb120b0 
Also added contributor's name to author file.
LB--
LB-- requested changes Aug 14, 2021
View reviewed changes
Copy link
Member

@LB-- LB-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I tried merging this but it breaks the build due to mismatched sign comparisons, the original definition of the macro was signed whereas this new macro is unsigned. Is it safe to just add a cast back to json_int_t?

Also, if you have a preference about your name being in the AUTHORS file, now would be the time to say so.

@LB-- LB-- linked an issue Aug 14, 2021 that may be closed by this pull request
Improve calculation of JSON_INT_MAX #84
Closed
This was referenced Aug 14, 2021
Merged
Closed
DimitriPapadopoulos
DimitriPapadopoulos suggested changes Aug 14, 2021
View reviewed changes
json.c
: (sizeof(json_int_t) == 4
? INT32_MAX
: INT64_MAX));
#define JSON_INT_MAX ((1UL << ((sizeof(json_int_t) * CHAR_BIT) - 1)) - 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a patch release such as 1.1.1, I would change as little code as possible:

static const json_int_t JSON_INT_MAX = (json_int_t)((1UL << ((sizeof(json_int_t) * CHAR_BIT) - 1)) - 1);

Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos Aug 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, 1UL is an unsigned long. What if json_int_t is larger than long?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a very good point, perhaps the alternative you proposed in #84 would be better then

DimitriPapadopoulos added a commit to DimitriPapadopoulos/json-parser that referenced this pull request Aug 16, 2021
@DimitriPapadopoulos
Define JSON_INT_MAX
1f4ad3f 
Either it has been defined explictly, or we attempt to calculate it
using the method reverted by fcfa748.

See discussion in json-parser#84 and json-parser#102.
DimitriPapadopoulos added a commit to DimitriPapadopoulos/json-parser that referenced this pull request Aug 16, 2021
@DimitriPapadopoulos
Define JSON_INT_MAX
e5026c1 
Either it has been defined explictly, or we attempt to calculate it
using the method reverted by fcfa748.

See discussion in json-parser#84 and json-parser#102.
DimitriPapadopoulos added a commit to DimitriPapadopoulos/json-parser that referenced this pull request Aug 18, 2021
@DimitriPapadopoulos
Define JSON_INT_MAX
37bc6e8 
Either it has been defined explictly, or we attempt to calculate it
using the method reverted by fcfa748.

See discussion in json-parser#84 and json-parser#102.
DimitriPapadopoulos added a commit to DimitriPapadopoulos/json-parser that referenced this pull request Aug 18, 2021
@DimitriPapadopoulos
Define JSON_INT_MAX
7ad64cc 
Either it has been defined explictly, or we attempt to calculate it
using the method reverted by fcfa748.

See discussion in json-parser#84 and json-parser#102.
DimitriPapadopoulos added a commit to DimitriPapadopoulos/json-parser that referenced this pull request Aug 19, 2021
@DimitriPapadopoulos
Define JSON_INT_MAX
29aeeff 
Either it has been defined explictly, or we attempt to calculate it
using the method reverted by fcfa748.

See discussion in json-parser#84 and json-parser#102.
DimitriPapadopoulos added a commit to DimitriPapadopoulos/json-parser that referenced this pull request Aug 29, 2021
@DimitriPapadopoulos
Define JSON_INT_MAX
ba3e0f9 
Either it has been defined explictly, or we attempt to calculate it
using the method reverted by fcfa748.

See discussion in json-parser#84 and json-parser#102.
DimitriPapadopoulos added a commit to DimitriPapadopoulos/json-parser that referenced this pull request Aug 29, 2021
@DimitriPapadopoulos
Define JSON_INT_MAX
72a3353 
Either it has been defined explictly, or we attempt to calculate it
using the method reverted by fcfa748.

See discussion in json-parser#84 and json-parser#102.
DimitriPapadopoulos added a commit to DimitriPapadopoulos/json-parser that referenced this pull request Oct 26, 2021
@DimitriPapadopoulos
Define JSON_INT_MAX
0ae60fb 
Either it has been defined explictly, or we attempt to calculate it
using the method reverted by fcfa748.

See discussion in json-parser#84 and json-parser#102.
@LB-- LB-- self-assigned this Oct 30, 2021
LB-- added a commit to LB--/json-parser that referenced this pull request Oct 31, 2021
@LB--
Better JSON_INT_MAX detection
3513fbe 
Fixes json-parser#84
Closes json-parser#102
Probably affects json-parser#115

In theory this should be guaranteed to work regardless of the underlying representation: https://stackoverflow.com/a/2711560/1959975

Demos for C++17 and C89:
https://gcc.godbolt.org/#z:OYLghAFBqd5QCxAYwPYBMCmBRdBLAF1QCcAaPECAMzwBtMA7AQwFtMQByARg9KtQYEAysib0QXACx8BBAKoBnTAAUAHpwAMvAFYTStJg1DIApACYAQuYukl9ZATwDKjdAGFUtAK4sGe1wAyeAyYAHI%2BAEaYxBIAHKQADqgKhE4MHt6%2BekkpjgJBIeEsUTFc8XaYDmlCBEzEBBk%2Bfly2mPZ5DDV1BAVhkdFxtrX1jVktCsM9wX3FA2UAlLaoXsTI7BzmAMxYNCEA1ABq2ABKAJIAYgCaAPpuAIIBbhDaCgLXwQTXBKR7DPN7LzeHy%2Bvy2W2uAFk7gANCD/EwAdgse2ImAIKwYe2erwY70EX3mUC8DBSwBC6ABOLxnwI8wAtFw9gB6LHE0nkylA/G0szzEybZGIgAiJg0d1F4rMmzwVB2e2u12QCW8CmVXgUEq2wWQ3iwe35bloeBYhA1m2wmqlO2mhxOF0u2K5NJ%2Bf31AFY3BK9t7ObjgQRQVLwSwmKo4fqkSi0Ri9hN0CAQAwfNE8MhrkaTQQzW5AX7ufzsAmQ2G%2BQKI0L3Z6xT7bWcrrcHk9c9Svi6%2BWKtm0lJbtphdpha/bB/X7o8e64ZZqxUc6w7kAg6j953VS1Zp3arhAFAgSN9Yzv6quJTP7RAPj8Pkf17OILQBMAfnejFe7ifN0/gHsP4/7x%2BX2%2BHQVD4uDMeI9mA0CXw4RZaE4N1eD8DgtFIVBOE9SxrFjZZVgHLYeFIAhNGgxYAGsQE2AA2AA6LhaK4CiNA0Lg3ViN1NjKfROEkBCiJQzheAUEANAIojFjgWAkDQFgEjoaJyEoKSZPoGJgFosw%2BDoAhokEiAIl4iJgjqABPTh8KkthBAAeQYWgTKQ3gsBDIxxHs0h8FRKoADdMEE1zMFUSovC00zeA%2BNpeKNCJiGMjwsF4ghiGNELFioAxgAUA48EwAB3SyEkYEKZEEEQxHYKQivkJQ1F43QWgMIwUGsax9DwCJBMgRZUASDpfLpON%2BSFMkvCaywuARPY6UszYJoAdTEWhZv8hKmEW4hiBIAS2kqDoXAYdxPCafw9t6IoSmyZJUgEUZmkSC6OhO/pSladpqkma69AqKoBC6eoHtmJ6Jm6d7xkmP6zq4RZXhWNY9ASzB1h4GC4J41zUI4VRYgoukKMkPZgGQZA9loqizCxdCrEsH5cEIEh9SlFo9g8aTZOIOn2PmXhCPs%2BZSPIjQqLdQW3Q0CiKOF2IuE2YWKM4jhuNIFgJEY0hEOQtGBKEkTudIcTEBQVBmeU%2BSIEUlmQFUkCNNoLTiB0vTXIM5hiDssyDYsghrNs3jHMMYAXOQ9ztrwbzfOQ/zAuC7hQsEcLXMi6Lndi9ZkISpKo5StKMqy3L8sQ/D%2BGK0RxHKgvKpUdRXN0dT6uMEabEi9q4RQ7q0l6/rNkGpNYgATgmqbZvmxbVGW1b1tZulVD2ZBNpe5wIFcYHSECaZTrmW7cjSReckuhgwbXz6Oh%2BhoDrGZ6g%2B%2B0GV8ej63pPm7Ad%2Bq//okSHsJhlo4YR6DZfglXeLRjGWMcZ4wJkTLgJMyZ1ypvgIgrM8I/CZkpaIbNeSc1ErzTYmwqKYJwbgvBst5aq14OrWwmsuZaB5rLMwKM1b8S1hQxY3lbZpBAJIIAA%3D%3D
@LB-- LB-- removed this from the v1.1.1 milestone Oct 31, 2021
@LB--
Copy link
Member

LB-- commented Oct 31, 2021 •
edited
Loading

Thank you for this, however after further research and consideration I believe #115 offers a better solution for this, so I'm closing this for now.

@LB-- LB-- closed this Oct 31, 2021
DimitriPapadopoulos added a commit to DimitriPapadopoulos/json-parser that referenced this pull request Oct 31, 2021
@DimitriPapadopoulos
Define JSON_INT_MAX
7b12984 
Either it has been defined explictly, or we attempt to calculate it
using the method reverted by fcfa748.

See discussion in json-parser#84 and json-parser#102.
@LB-- LB-- removed a link to an issue Nov 2, 2021
Improve calculation of JSON_INT_MAX #84
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LB-- LB-- LB-- requested changes

@DimitriPapadopoulos DimitriPapadopoulos DimitriPapadopoulos requested changes

Assignees

@LB-- LB--

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@per-ok @LB-- @DimitriPapadopoulos