Fix for a bug in unicode surrogate pair handling #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eg: the JSON string "\ud841\udf31" should contain the character with the unicode scalar value U+20731, not U+10731
|
@LB-- I'm wondering whether this should be added to the v1.1.1 milestone. It looks like Unicode strings are not read correctly. @bogbert It would be great if a test could be added. File |
|
I've added some basic string comparison tests in 174e5a7 as a good starting point for this. It seems like this change does in fact fix the issue, but I'll want to get more comparisons in the tests first to make sure nothing else gets broken. |
|
See for example: I have forked the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eg: the JSON string "\ud841\udf31" should contain the character with the unicode scalar value U+20731, not U+10731