Enable C++ iterators in MSVC (and C++98) #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for MSVC and (rather coincidentally) C++98 by replacing the decltype keyword and removing the corresponding preprocessor checks.
|
In Visual Studio 2017 you should specify Though, if this change works without needing to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterators (begin() and end() methods) were implemented using
decltypefor the return types, which seems to be possible only since C++11. Therefore, the code used the value of the__cpluspluspre-processor symbol to check for C++11. This did not work as expected in MSVC, however, because even the recent Visual Studio 2017 defines the symbol as 199711L, effectively disabling iterators.Replaced the
decltypeusages with the respective type names; and no longer check the value of__cplusplus. Iterators are now available in MSVC and, as a side-effect, also in C++98.Tested with Visual Studio 2017 (version 15.6.3) and "g++ -std=c++98".